fix: dashlet detail shows actual items instead of empty alerts

Cards "תיקים פתוחים" and "דיונים השבוע" showed counts but clicking
revealed "אין פריטים להצגה" because card counts came from direct DB
queries while detail filtered from alerts with stricter criteria.

Added getOpenCaseItems() and getUpcomingHearingItems() to AlertCalculator,
included them in summary API response, and wired dashlet to use them.

Also: renamed extension to SmartAssistant, title to "שירה — עוזרת אישית".

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

README.md

@@ -1,12 +1,10 @@
 # SmartAssistant - עוזר חכם
 
-**גרסה:** 1.0.1 | **מחבר:** klear | **EspoCRM:** >= 8.0.0
+**גרסה:** 1.1.0 | **מחבר:** klear | **EspoCRM:** >= 8.0.0
 
 ## תיאור
 עוזר AI מאוחד למשרד עורכי דין. מספק ממשק צ'אט צף עם שני מצבי עבודה: **מצב משרד** (סקירה כללית, התראות, סטטיסטיקות) ו**מצב תיק** (סיוע מעמיק בתיק ספציפי). כולל מערכת זיכרון תיק מובנית, ביצוע פעולות באישור המשתמש, ואינטגרציה עם Stream של EspoCRM.
 
-מחליף את CrmAssistant + OfficeAssistant (deprecated).
-
 ## תלויות
 - Webhook חיצוני (n8n או דומה) לעיבוד AI
 - NetworkStorageIntegration / NextCloudIntegration (אופציונלי — לניתוח מסמכים)

files/client/custom/modules/smart-assistant/src/views/dashlets/smart-assistant.js

@@ -5,38 +5,68 @@ define('modules/smart-assistant/views/dashlets/smart-assistant', ['view'], funct
         name: 'SmartAssistant',
 
         getTitle: function () {
-            return this.translate('Smart Assistant', 'labels', 'SmartAssistant') || 'Smart Assistant';
+            return 'שירה — עוזרת אישית';
         },
 
         templateContent: '' +
             '<div style="direction: rtl; text-align: right; padding: 8px;">' +
             '<div class="sa-dashlet-cards" style="display: flex; gap: 8px; flex-wrap: wrap; margin-bottom: 12px;"></div>' +
-            '<div class="sa-dashlet-alerts" style="max-height: 200px; overflow-y: auto;"></div>' +
+            '<div class="sa-dashlet-detail" style="max-height: 250px; overflow-y: auto;"></div>' +
             '</div>',
 
+        events: {
+            'click .sa-card': function (e) {
+                var type = $(e.currentTarget).data('type');
+                this.showDetail(type);
+            },
+        },
+
         afterRender: function () {
-            this.loadSummary();
+            this._alerts = [];
+            this._summary = {};
+            this._activeType = null;
+
+            var self = this;
+            Espo.Ajax.getRequest('SmartAssistant/action/status').then(function (result) {
+                if (!result.enabled) {
+                    self.$el.find('.sa-dashlet-cards').html(
+                        '<div style="text-align: center; color: #999; padding: 20px; font-size: 13px;">שירה לא מופעלת. הפעל ב-Admin &gt; Integrations &gt; Smart Assistant</div>'
+                    );
+                    return;
+                }
+                self.loadSummary();
+            }).catch(function () {
+                self.loadSummary();
+            });
         },
 
         loadSummary: function () {
             var self = this;
             Espo.Ajax.getRequest('SmartAssistant/action/summary').then(function (response) {
-                self.renderCards(response.summary || {});
-                self.renderAlerts(response.alerts || []);
+                self._summary = response.summary || {};
+                self._alerts = response.alerts || [];
+                self._openCases = response.openCases || [];
+                self._upcomingHearings = response.upcomingHearings || [];
+                self.renderCards(self._summary);
+                self.showDetail(self._activeType);
             }).catch(function () {});
         },
 
         renderCards: function (summary) {
             var cards = [
-                {label: 'תיקים פתוחים', value: summary.totalOpenCases || 0, color: '#1565c0', bg: '#e3f2fd', icon: 'fa-folder-open'},
-                {label: 'משימות באיחור', value: summary.totalOverdueTasks || 0, color: '#c62828', bg: '#ffcdd2', icon: 'fa-exclamation-circle'},
-                {label: 'דיונים השבוע', value: summary.upcomingHearings7d || 0, color: '#e65100', bg: '#fff3e0', icon: 'fa-gavel'},
-                {label: 'דורשים תשומת לב', value: summary.casesNeedingAttention || 0, color: '#f9a825', bg: '#fff9c4', icon: 'fa-bell'},
+                {type: 'open', label: 'תיקים פתוחים', value: summary.totalOpenCases || 0, color: '#1565c0', bg: '#e3f2fd', icon: 'fa-folder-open'},
+                {type: 'overdue', label: 'משימות באיחור', value: summary.totalOverdueTasks || 0, color: '#c62828', bg: '#ffcdd2', icon: 'fa-exclamation-circle'},
+                {type: 'hearings', label: 'דיונים השבוע', value: summary.upcomingHearings7d || 0, color: '#e65100', bg: '#fff3e0', icon: 'fa-gavel'},
+                {type: 'attention', label: 'דורשים תשומת לב', value: summary.casesNeedingAttention || 0, color: '#f9a825', bg: '#fff9c4', icon: 'fa-bell'},
             ];
 
+            var self = this;
             var html = '';
             cards.forEach(function (c) {
-                html += '<div style="flex: 1; min-width: 80px; background: ' + c.bg + '; padding: 10px; border-radius: 8px; text-align: center;">' +
+                var active = self._activeType === c.type;
+                var border = active ? '2px solid ' + c.color : '2px solid transparent';
+                var cursor = c.value > 0 ? 'pointer' : 'default';
+                html += '<div class="sa-card" data-type="' + c.type + '" style="flex: 1; min-width: 80px; background: ' + c.bg + '; padding: 10px; border-radius: 8px; text-align: center; cursor: ' + cursor + '; border: ' + border + '; transition: border 0.2s;">' +
                     '<div style="font-size: 22px; font-weight: bold; color: ' + c.color + ';">' + c.value + '</div>' +
                     '<div style="font-size: 11px; color: ' + c.color + ';"><span class="fas ' + c.icon + '"></span> ' + c.label + '</div>' +
                     '</div>';
@@ -45,10 +75,35 @@ define('modules/smart-assistant/views/dashlets/smart-assistant', ['view'], funct
             this.$el.find('.sa-dashlet-cards').html(html);
         },
 
-        renderAlerts: function (alerts) {
-            var $alerts = this.$el.find('.sa-dashlet-alerts');
-            if (alerts.length === 0) {
-                $alerts.html('<div style="text-align: center; color: #4caf50; padding: 12px;">אין התראות</div>');
+        showDetail: function (type) {
+            var $detail = this.$el.find('.sa-dashlet-detail');
+
+            if (!type || type === this._activeType && $detail.html()) {
+                // Toggle off
+                this._activeType = null;
+                $detail.html('');
+                this.renderCards(this._summary);
+                return;
+            }
+
+            this._activeType = type;
+            this.renderCards(this._summary);
+
+            var alerts = this._alerts;
+            var items = [];
+
+            if (type === 'overdue') {
+                items = alerts.filter(function (a) { return a.type === 'overdue_task'; });
+            } else if (type === 'hearings') {
+                items = this._upcomingHearings || [];
+            } else if (type === 'attention') {
+                items = alerts.filter(function (a) { return a.severity === 'critical' || a.severity === 'warning'; });
+            } else if (type === 'open') {
+                items = this._openCases || [];
+            }
+
+            if (items.length === 0) {
+                $detail.html('<div style="text-align: center; color: #999; padding: 12px; font-size: 12px;">אין פריטים להצגה</div>');
                 return;
             }
 
@@ -56,21 +111,36 @@ define('modules/smart-assistant/views/dashlets/smart-assistant', ['view'], funct
             var severityIcons = {critical: 'fa-exclamation-circle', warning: 'fa-exclamation-triangle', info: 'fa-info-circle'};
 
             var html = '';
-            alerts.slice(0, 10).forEach(function (a) {
+            items.forEach(function (a) {
                 var color = severityColors[a.severity] || '#333';
                 var icon = severityIcons[a.severity] || 'fa-circle';
+                var link = a.caseId ? '<a href="#Case/view/' + a.caseId + '" style="color: ' + color + '; text-decoration: none;">' : '<span>';
+                var linkEnd = a.caseId ? '</a>' : '</span>';
 
-                html += '<div style="padding: 6px 0; border-bottom: 1px solid #f5f5f5; font-size: 12px; color: ' + color + ';">' +
+                html += '<div style="padding: 6px 8px; border-bottom: 1px solid #f0f0f0; font-size: 12px; color: ' + color + ';">' +
                     '<span class="fas ' + icon + '" style="margin-left: 6px;"></span>' +
-                    '<span>' + Espo.Utils.escapeString(a.message) + '</span>' +
+                    link + Espo.Utils.escapeString(a.message) + linkEnd +
                     '</div>';
             });
 
-            $alerts.html(html);
+            $detail.html(html);
         },
 
         actionRefresh: function () {
             this.loadSummary();
         },
+
+        getActionItemDataList: function () {
+            return [
+                {
+                    name: 'refresh',
+                    iconHtml: '<span class="fas fa-sync-alt"></span>',
+                },
+            ];
+        },
+
+        getColor: function () {
+            return '#5c6bc0';
+        },
     });
 });

files/client/custom/modules/smart-assistant/src/views/floating-chat.js

@@ -158,10 +158,22 @@ define('modules/smart-assistant/views/floating-chat', ['view'], function (View)
         },
 
         afterRender: function () {
-            this.$el.find('.sa-chat-messages').attr('data-empty-text',
-                this.translate('Chat with the assistant', 'labels', 'SmartAssistant') || 'שוחח/י עם העוזר החכם');
-            this.loadAlertCount();
-            this._setupRouteListener();
+            var self = this;
+
+            Espo.Ajax.getRequest('SmartAssistant/action/status').then(function (result) {
+                if (!result.enabled) {
+                    self.$el.find('.sa-fab').hide();
+                    return;
+                }
+
+                self.$el.find('.sa-fab').show();
+                self.$el.find('.sa-chat-messages').attr('data-empty-text',
+                    self.translate('Chat with the assistant', 'labels', 'SmartAssistant') || 'שוחח/י עם העוזר החכם');
+                self.loadAlertCount();
+                self._setupRouteListener();
+            }).catch(function () {
+                self.$el.find('.sa-fab').hide();
+            });
         },
 
         _setupRouteListener: function () {

files/custom/Espo/Modules/SmartAssistant/Controllers/SmartAssistant.php

@@ -34,6 +34,11 @@ class SmartAssistant
         }
     }
 
+    public function getActionStatus(Request $request, Response $response): array
+    {
+        return $this->getService()->getStatus();
+    }
+
     public function postActionChat(Request $request, Response $response): array
     {
         $this->checkAccess();

files/custom/Espo/Modules/SmartAssistant/Resources/i18n/en_US/AssistantConversation.json

@@ -0,0 +1 @@
+{"labels":{"Create AssistantConversation":"New Conversation"},"fields":{"name":"Title","conversationKey":"Conversation Key","conversationType":"Type","status":"Status","assignedUser":"User","case":"Case","caseName":"Case Name","messageCount":"Messages","messagesData":"Messages Data","lastMessageAt":"Last Message","lastMessagePreview":"Preview","createdAt":"Created At","modifiedAt":"Modified At","createdBy":"Created By","modifiedBy":"Modified By"},"links":{"assignedUser":"User","case":"Case"},"options":{"conversationType":{"office":"Office","case":"Case"}}}

files/custom/Espo/Modules/SmartAssistant/Resources/i18n/fa_IR/AssistantConversation.json

@@ -0,0 +1 @@
+{"labels":{"Create AssistantConversation":"שיחה חדשה"},"fields":{"name":"כותרת","conversationKey":"מזהה שיחה","conversationType":"סוג","status":"סטטוס","assignedUser":"משתמש","case":"תיק","caseName":"שם התיק","messageCount":"הודעות","messagesData":"נתוני הודעות","lastMessageAt":"הודעה אחרונה","lastMessagePreview":"תצוגה מקדימה","createdAt":"נוצר ב","modifiedAt":"עודכן ב","createdBy":"נוצר על ידי","modifiedBy":"עודכן על ידי"},"links":{"assignedUser":"משתמש","case":"תיק"},"options":{"conversationType":{"office":"משרד","case":"תיק"}}}

files/custom/Espo/Modules/SmartAssistant/Resources/i18n/fa_IR/SmartAssistant.json

@@ -1,6 +1,6 @@
 {
     "labels": {
-        "Smart Assistant": "עוזר חכם",
+        "Smart Assistant": "שירה",
         "Office Mode": "מצב משרד",
         "Case Mode": "מצב תיק",
         "Add Memory": "הוסף זיכרון",
@@ -9,11 +9,11 @@
         "Conversation History": "היסטוריית שיחות",
         "Previous Conversations": "שיחות קודמות",
         "No previous conversations": "אין שיחות קודמות",
-        "Ask the assistant...": "שאל/י את העוזר...",
+        "Ask the assistant...": "שאל/י את שירה...",
         "Thinking": "חושב...",
         "Error": "שגיאה בתקשורת",
         "Back": "חזרה",
-        "Chat with the assistant": "שוחח/י עם העוזר החכם",
+        "Chat with the assistant": "שוחח/י עם שירה",
         "Case Memory": "זיכרון תיק",
         "Pin": "הצמד",
         "Unpin": "הסר הצמדה",

files/custom/Espo/Modules/SmartAssistant/Resources/metadata/entityDefs/AssistantConversation.json

@@ -0,0 +1 @@
+{"fields":{"name":{"type":"varchar","maxLength":255,"required":true},"conversationKey":{"type":"varchar","maxLength":255,"required":true},"conversationType":{"type":"enum","options":["office","case"],"default":"office","required":true},"status":{"type":"varchar","maxLength":50,"default":"Active"},"assignedUser":{"type":"link"},"case":{"type":"link"},"caseName":{"type":"varchar","maxLength":255},"messageCount":{"type":"int","default":0},"messagesData":{"type":"jsonArray"},"lastMessageAt":{"type":"datetime"},"lastMessagePreview":{"type":"text","maxLength":200},"createdAt":{"type":"datetime","readOnly":true},"modifiedAt":{"type":"datetime","readOnly":true},"createdBy":{"type":"link","readOnly":true},"modifiedBy":{"type":"link","readOnly":true}},"links":{"assignedUser":{"type":"belongsTo","entity":"User"},"case":{"type":"belongsTo","entity":"Case"},"createdBy":{"type":"belongsTo","entity":"User"},"modifiedBy":{"type":"belongsTo","entity":"User"}},"collection":{"orderBy":"lastMessageAt","order":"desc","textFilterFields":["name","lastMessagePreview"]},"indexes":{"conversationKey":{"columns":["conversationKey","deleted"],"type":"unique"},"assignedUser":{"columns":["assignedUserId","deleted"]},"caseId":{"columns":["caseId","deleted"]},"conversationType":{"columns":["conversationType","deleted"]}}}

files/custom/Espo/Modules/SmartAssistant/Resources/metadata/scopes/AssistantConversation.json

@@ -0,0 +1 @@
+{"entity":true,"object":true,"module":"SmartAssistant","acl":true,"aclActionList":["create","read","edit","delete"],"aclLevelList":["all","team","own","no"],"tab":false,"stream":false,"disabled":false,"importable":false,"customizable":false}

files/custom/Espo/Modules/SmartAssistant/Resources/module.json

@@ -5,5 +5,6 @@
         "espocrm": ">=8.0.0"
     },
     "author": "klear",
-    "description": "Unified AI Assistant for Legal CRM"
+    "description": "Unified AI Assistant for Legal CRM",
+    "clientModule": "smart-assistant"
 }

files/custom/Espo/Modules/SmartAssistant/Resources/routes.json

@@ -1,4 +1,12 @@
 [
+    {
+        "route": "/SmartAssistant/action/status",
+        "method": "get",
+        "params": {
+            "controller": "SmartAssistant",
+            "action": "status"
+        }
+    },
     {
         "route": "/SmartAssistant/action/chat",
         "method": "post",

files/custom/Espo/Modules/SmartAssistant/Services/AlertCalculator.php

@@ -243,6 +243,78 @@ class AlertCalculator
         return array_values($userCounts);
     }
 
+    public function getOpenCaseItems(int $limit = 30): array
+    {
+        $items = [];
+        $cases = $this->entityManager->getRDBRepository('Case')
+            ->select(['id', 'name', 'status', 'assignedUserName', 'cLastActivityAt', 'createdAt'])
+            ->where(['status!=' => self::CLOSED_STATUSES, 'deleted' => false])
+            ->order('createdAt', 'DESC')
+            ->limit(0, $limit)
+            ->find();
+
+        $statusLabels = [
+            'New' => 'חדש', 'Assigned' => 'שובץ', 'Pending' => 'ממתין',
+            'PendingHearing' => 'ממתין לדיון', 'PendingDecision' => 'ממתין להחלטה',
+            'PendingResponse' => 'ממתין לתגובה', 'Negotiation' => 'משא ומתן', 'Suspended' => 'מושהה',
+        ];
+
+        foreach ($cases as $case) {
+            $status = $case->get('status');
+            $label = $statusLabels[$status] ?? $status;
+            $assigned = $case->get('assignedUserName');
+
+            $items[] = [
+                'type' => 'open_case',
+                'severity' => 'info',
+                'caseId' => $case->get('id'),
+                'caseName' => $case->get('name'),
+                'message' => $case->get('name') . ' — ' . $label . ($assigned ? ' (' . $assigned . ')' : ''),
+            ];
+        }
+        return $items;
+    }
+
+    public function getUpcomingHearingItems(int $days = 7): array
+    {
+        $today = date('Y-m-d');
+        $threshold = date('Y-m-d', strtotime("+{$days} days"));
+        $items = [];
+
+        $cases = $this->entityManager->getRDBRepository('Case')
+            ->select(['id', 'name', 'cNextHearing', 'cCourt', 'assignedUserName'])
+            ->where([
+                'cNextHearing>=' => $today,
+                'cNextHearing<=' => $threshold,
+                'status!=' => self::CLOSED_STATUSES,
+                'deleted' => false,
+            ])
+            ->order('cNextHearing', 'ASC')
+            ->find();
+
+        foreach ($cases as $case) {
+            $daysUntil = (new \DateTime())->diff(new \DateTime($case->get('cNextHearing')))->days;
+            $court = $case->get('cCourt');
+            $severity = ($daysUntil <= 1) ? 'warning' : 'info';
+
+            $msg = $case->get('name') . ' — דיון בעוד ' . $daysUntil . ' ימים';
+            if ($court) {
+                $msg .= ' (' . $court . ')';
+            }
+
+            $items[] = [
+                'type' => 'upcoming_hearing',
+                'severity' => $severity,
+                'caseId' => $case->get('id'),
+                'caseName' => $case->get('name'),
+                'hearingDate' => $case->get('cNextHearing'),
+                'daysUntil' => $daysUntil,
+                'message' => $msg,
+            ];
+        }
+        return $items;
+    }
+
     public function getUpcomingHearings(int $days = 7): array
     {
         $today = date('Y-m-d');

files/custom/Espo/Modules/SmartAssistant/Services/SmartAssistantService.php

@@ -236,14 +236,27 @@ class SmartAssistantService
         }
     }
 
+    public function getStatus(): array
+    {
+        $webhookUrl = $this->getWebhookUrl();
+
+        return [
+            'enabled' => $webhookUrl !== null,
+            'webhookConfigured' => !empty($webhookUrl),
+        ];
+    }
+
     public function getSummary(): array
     {
         $alertCalc = $this->injectableFactory->create(AlertCalculator::class);
         $thresholds = $this->getThresholds();
+        $hearingDays = $thresholds['upcomingHearingDays'] ?? 7;
 
         return [
             'summary' => $alertCalc->getSummary(),
             'alerts' => $alertCalc->calculateAlerts($thresholds),
+            'openCases' => $alertCalc->getOpenCaseItems(),
+            'upcomingHearings' => $alertCalc->getUpcomingHearingItems($hearingDays),
         ];
     }
 
@@ -406,14 +419,11 @@ class SmartAssistantService
 
     private function getWebhookUrl(): ?string
     {
-        // Try SmartAssistant first, then fallback to old integrations
-        foreach (['SmartAssistant', 'CrmAssistant', 'OfficeAssistant'] as $name) {
-            $integration = $this->entityManager->getEntityById('Integration', $name);
-            if ($integration && $integration->get('enabled')) {
-                $data = $integration->get('data') ?? (object) [];
-                if (!empty($data->webhookUrl)) {
-                    return $data->webhookUrl;
-                }
+        $integration = $this->entityManager->getEntityById('Integration', 'SmartAssistant');
+        if ($integration && $integration->get('enabled')) {
+            $data = $integration->get('data') ?? (object) [];
+            if (!empty($data->webhookUrl)) {
+                return $data->webhookUrl;
             }
         }
         return null;
@@ -421,13 +431,11 @@ class SmartAssistantService
 
     private function getApiKey(): ?string
     {
-        foreach (['SmartAssistant', 'CrmAssistant', 'OfficeAssistant'] as $name) {
-            $integration = $this->entityManager->getEntityById('Integration', $name);
-            if ($integration && $integration->get('enabled')) {
-                $data = $integration->get('data') ?? (object) [];
-                if (!empty($data->apiKey)) {
-                    return $data->apiKey;
-                }
+        $integration = $this->entityManager->getEntityById('Integration', 'SmartAssistant');
+        if ($integration && $integration->get('enabled')) {
+            $data = $integration->get('data') ?? (object) [];
+            if (!empty($data->apiKey)) {
+                return $data->apiKey;
             }
         }
         return null;
@@ -435,16 +443,14 @@ class SmartAssistantService
 
     private function getThresholds(): array
     {
-        foreach (['SmartAssistant', 'OfficeAssistant'] as $name) {
-            $integration = $this->entityManager->getEntityById('Integration', $name);
-            if ($integration && $integration->get('enabled')) {
-                $data = (array) ($integration->get('data') ?? []);
-                return [
-                    'inactivityWarningDays' => $data['inactivityWarningDays'] ?? 14,
-                    'inactivityCriticalDays' => $data['inactivityCriticalDays'] ?? 30,
-                    'upcomingHearingDays' => $data['upcomingHearingDays'] ?? 7,
-                ];
-            }
+        $integration = $this->entityManager->getEntityById('Integration', 'SmartAssistant');
+        if ($integration && $integration->get('enabled')) {
+            $data = (array) ($integration->get('data') ?? []);
+            return [
+                'inactivityWarningDays' => $data['inactivityWarningDays'] ?? 14,
+                'inactivityCriticalDays' => $data['inactivityCriticalDays'] ?? 30,
+                'upcomingHearingDays' => $data['upcomingHearingDays'] ?? 7,
+            ];
         }
         return [];
     }

manifest.json

@@ -1,9 +1,9 @@
 {
-    "name": "Smart Assistant",
+    "name": "SmartAssistant",
     "module": "SmartAssistant",
     "description": "Unified AI Assistant for Legal CRM — floating chat with case memory, office alerts, and n8n integration",
     "author": "klear",
-    "version": "1.0.1",
+    "version": "1.1.0",
     "acceptableVersions": [
         ">=8.0.0"
     ],