Fix critical bug: rooms filter not working due to missing alias

The Deal model's 'rooms' field was missing the 'assetRoomNum' alias,
causing room data from the API to not be loaded into the model.
This resulted in all room-based filters returning 0 results.

Bug discovered when querying "חנקין 62 חולון" for 3-room apartments.
Query returned 0 results despite multiple 3-room deals existing in the data.

Root cause: Pydantic requires field aliases to map API field names (camelCase)
to Python attributes (snake_case). The 'rooms' field had no alias.

Fix: Added alias="assetRoomNum" to rooms field in Deal model.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Nitzan P
2025-11-17 23:42:31 +02:00
parent 87b0a355f8
commit 96ec29dad2
+1 -1
View File
@@ -132,7 +132,7 @@ class Deal(BaseModel):
)
# Additional details
rooms: Optional[float] = Field(None, description="Number of rooms")
rooms: Optional[float] = Field(None, alias="assetRoomNum", description="Number of rooms")
# Priority and metadata (added by our system, not from API)
priority: Optional[int] = Field(