mcp-servers/nadlan-mcp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix autocomplete non-determinism causing 0 deals

Browse Source 
Autocomplete returns different coordinates for vague queries (e.g. "תל אביב דיזנגוף"),
sometimes landing on points with no nearby polygon_ids within 30m radius.

- Try top 3 autocomplete results until one has polygons
- Fallback radius expansion (30m→200m) if no polygons found
- Fix limit validation bug (min 1 for deal queries)

Fixes: compare_addresses, get_valuation_comparables, get_deal_statistics

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Nitzan Pomerantz
2025-11-14 23:48:12 +02:00
parent 58c55f14a7
commit 865aae1b73
1 changed files with 49 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nadlan_mcp/govmap/client.py
+49 -12
View File
@@ -559,18 +559,53 @@ class GovmapClient:
if not autocomplete_result.results:
raise ValueError(f"No results found for address: {address}")
# Get the best match (first result)
best_match = autocomplete_result.results[0]
if not best_match.coordinates:
raise ValueError("No coordinates found in autocomplete result")
# Try multiple autocomplete results to find one with nearby polygons
# (autocomplete can return different coordinates for vague queries)
nearby_polygons = []
point = None
for result in autocomplete_result.results[:3]: # Try top 3 results
if not result.coordinates:
continue
test_point = (result.coordinates.longitude, result.coordinates.latitude)
test_polygons = self.get_deals_by_radius(test_point, radius=radius)
if test_polygons:
point = test_point
nearby_polygons = test_polygons
logger.info(
f"Using autocomplete result: '{result.text}' with {len(test_polygons)} polygons"
)
break
# Fallback: if no results had polygons at specified radius, try expanding radius
if not nearby_polygons and radius < 200:
logger.warning(f"No polygons found at {radius}m radius, expanding to 200m")
# Use first result with coordinates for expanded search
for result in autocomplete_result.results[:3]:
if result.coordinates:
test_point = (result.coordinates.longitude, result.coordinates.latitude)
nearby_polygons = self.get_deals_by_radius(test_point, radius=200)
if nearby_polygons:
point = test_point
logger.info(
f"Found {len(nearby_polygons)} polygons at expanded 200m radius"
)
break
# Final fallback: use first result even if no polygons (will return empty results)
if not point:
best_match = autocomplete_result.results[0]
if not best_match.coordinates:
raise ValueError("No coordinates found in any autocomplete result")
point = (best_match.coordinates.longitude, best_match.coordinates.latitude)
logger.warning(
f"No polygons found for '{best_match.text}', will return empty results"
)
# Use coordinates from the model
point = (best_match.coordinates.longitude, best_match.coordinates.latitude)
search_address_normalized = address.lower().strip()
logger.info(f"Found coordinates: {point}")
# Step 2: Get polygon metadata by radius to find polygon IDs
nearby_polygons = self.get_deals_by_radius(point, radius=radius)
logger.info(f"Using coordinates: {point}")
# Extract unique polygon IDs from metadata dicts
polygon_ids = set()
@@ -612,7 +647,7 @@ class GovmapClient:
# Get street deals first (higher priority)
current_street_deals = self.get_street_deals(
polygon_id,
limit=max_deals // 2, # Allocate more to street deals
limit=max(1, max_deals // 2), # Allocate more to street deals (min 1)
start_date=start_date_str,
end_date=end_date_str,
deal_type=deal_type,
@@ -624,7 +659,9 @@ class GovmapClient:
if len(street_deals) < max_deals // 2:
current_neighborhood_deals = self.get_neighborhood_deals(
polygon_id,
limit=max_deals // 4, # Allocate less to neighborhood deals
limit=max(
1, max_deals // 4
), # Allocate less to neighborhood deals (min 1)
start_date=start_date_str,
end_date=end_date_str,
deal_type=deal_type,