fix x-skip-duplicate-check header

2021-09-01 15:51:46 +03:00
parent 5861aa11c1
commit ee2a3c9bea
2 changed files with 124 additions and 2 deletions
@@ -41,8 +41,8 @@ class CreateParamsFetcher
    {
        $data = $request->getParsedBody();

-        $skipDuplicateCheck =
-            $request->getHeader('X-Skip-Duplicate-Check') ??
+        $skipDuplicateCheck = $request->hasHeader('X-Skip-Duplicate-Check') ?
+            strtolower($request->getHeader('X-Skip-Duplicate-Check')) === 'true' :
            $data->_skipDuplicateCheck ?? // legacy
            $data->skipDuplicateCheck ?? // legacy
            $data->forceDuplicate ?? // legacy
@@ -0,0 +1,122 @@
+<?php
+/************************************************************************
+ * This file is part of EspoCRM.
+ *
+ * EspoCRM - Open Source CRM application.
+ * Copyright (C) 2014-2021 Yurii Kuznietsov, Taras Machyshyn, Oleksii Avramenko
+ * Website: https://www.espocrm.com
+ *
+ * EspoCRM is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * EspoCRM is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with EspoCRM. If not, see http://www.gnu.org/licenses/.
+ *
+ * The interactive user interfaces in modified source and object code versions
+ * of this program must display Appropriate Legal Notices, as required under
+ * Section 5 of the GNU General Public License version 3.
+ *
+ * In accordance with Section 7(b) of the GNU General Public License version 3,
+ * these Appropriate Legal Notices must retain the display of the "EspoCRM" word.
+ ************************************************************************/
+
+namespace tests\unit\Espo\Core\Record;
+
+use Espo\Core\Record\CreateParamsFetcher;
+use Espo\Core\Api\RequestWrapper;
+
+class CreateParamsFetcherTest extends \PHPUnit\Framework\TestCase
+{
+    public function test1(): void
+    {
+        $request = $this->createMock(RequestWrapper::class);
+
+        $request
+            ->method('hasHeader')
+            ->willReturn(true);
+
+        $request
+            ->method('getHeader')
+            ->with('X-Skip-Duplicate-Check')
+            ->willReturn('true');
+
+        $params = (new CreateParamsFetcher())->fetch($request);
+
+        $this->assertTrue($params->skipDuplicateCheck());
+    }
+
+    public function test2(): void
+    {
+        $request = $this->createMock(RequestWrapper::class);
+
+        $request
+            ->method('hasHeader')
+            ->willReturn(true);
+
+        $request
+            ->method('getHeader')
+            ->with('X-Skip-Duplicate-Check')
+            ->willReturn('false');
+
+        $params = (new CreateParamsFetcher())->fetch($request);
+
+        $this->assertFalse($params->skipDuplicateCheck());
+    }
+
+    public function test3(): void
+    {
+        $request = $this->createMock(RequestWrapper::class);
+
+        $request
+            ->method('hasHeader')
+            ->willReturn(false);
+
+        $params = (new CreateParamsFetcher())->fetch($request);
+
+        $this->assertFalse($params->skipDuplicateCheck());
+    }
+
+    public function test4(): void
+    {
+        $request = $this->createMock(RequestWrapper::class);
+
+        $request
+            ->method('hasHeader')
+            ->willReturn(true);
+
+        $request
+            ->method('getHeader')
+            ->with('X-Skip-Duplicate-Check')
+            ->willReturn('TRUE');
+
+        $params = (new CreateParamsFetcher())->fetch($request);
+
+        $this->assertTrue($params->skipDuplicateCheck());
+    }
+
+    public function test5(): void
+    {
+        $request = $this->createMock(RequestWrapper::class);
+
+        $request
+            ->method('hasHeader')
+            ->willReturn(false);
+
+        $request
+            ->method('getParsedBody')
+            ->willReturn((object) [
+                '_skipDuplicateCheck' => true,
+            ]);
+
+        $params = (new CreateParamsFetcher())->fetch($request);
+
+        $this->assertTrue($params->skipDuplicateCheck());
+    }
+}