espocrm-extensions/espocrm-base
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

email phone fields save fix

Browse Source
This commit is contained in:
Yuri Kuznetsov
2024-02-07 09:42:59 +02:00
parent fec6bf8ee0
commit 623b26f60f
4 changed files with 44 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
application/Espo/Core/FieldProcessing/EmailAddress/Saver.php
+1 -1
View File
@@ -69,7 +69,7 @@ class Saver implements SaverInterface
$emailAddressData = $entity->get('emailAddressData');
}
if ($emailAddressData !== null) {
if ($emailAddressData !== null && $entity->isAttributeChanged('emailAddressData')) {
$this->storeData($entity);
return;
application/Espo/Core/FieldProcessing/PhoneNumber/Saver.php
+1 -1
View File
@@ -74,7 +74,7 @@ class Saver implements SaverInterface
$phoneNumberData = $entity->get('phoneNumberData');
}
if ($phoneNumberData !== null) {
if ($phoneNumberData !== null && $entity->isAttributeChanged('phoneNumberData')) {
$this->storeData($entity);
return;
tests/integration/Espo/Core/FieldProcessing/EmailAddressTest.php
+21 -1
View File
@@ -31,10 +31,12 @@ namespace tests\integration\Espo\Core\FieldProcessing;
use Espo\Core\ORM\EntityManager;
use Espo\Modules\Crm\Entities\Contact;
use Espo\Core\{
Field\EmailAddressGroup,
Field\EmailAddress,
};
Record\ServiceContainer,
Record\UpdateParams};
class EmailAddressTest extends \tests\integration\Core\BaseTestCase
{
@@ -120,4 +122,22 @@ class EmailAddressTest extends \tests\integration\Core\BaseTestCase
$this->assertEquals('test@test.com', $group->getPrimary()->getAddress());
}
public function testEmailAddress3(): void
{
$service = $this->getContainer()->getByClass(ServiceContainer::class)->getByClass(Contact::class);
$em = $this->getEntityManager();
/** @var Contact $contact */
$contact = $em->createEntity(Contact::ENTITY_TYPE);
/** @noinspection PhpUnhandledExceptionInspection */
$service->update($contact->getId(), (object) [
'emailAddress' => 'test@test.com',
], UpdateParams::create());
$em->refreshEntity($contact);
$this->assertEquals('test@test.com', $contact->getEmailAddress());
}
}
tests/integration/Espo/Core/FieldProcessing/PhoneNumberTest.php
+21 -1
View File
@@ -31,10 +31,12 @@ namespace tests\integration\Espo\Core\FieldProcessing;
use Espo\Core\ORM\EntityManager;
use Espo\Modules\Crm\Entities\Contact;
use Espo\Core\{
Field\PhoneNumberGroup,
Field\PhoneNumber,
};
Record\ServiceContainer,
Record\UpdateParams};
class PhoneNumberTest extends \tests\integration\Core\BaseTestCase
{
@@ -99,4 +101,22 @@ class PhoneNumberTest extends \tests\integration\Core\BaseTestCase
$this->assertEquals(1, $group5->getCount());
}
public function testPhoneNumber2(): void
{
$service = $this->getContainer()->getByClass(ServiceContainer::class)->getByClass(Contact::class);
$em = $this->getEntityManager();
/** @var Contact $contact */
$contact = $em->createEntity(Contact::ENTITY_TYPE);
/** @noinspection PhpUnhandledExceptionInspection */
$service->update($contact->getId(), (object) [
'phoneNumber' => '+11111111111',
], UpdateParams::create());
$em->refreshEntity($contact);
$this->assertEquals('+11111111111', $contact->getPhoneNumber());
}
}