fix missing class imports, exceptions and undefined properties (#2112)

* fix exception

* fix missing imports

* fix access to an undefined property

application/Espo/Controllers/InboundEmail.php

@@ -29,6 +29,7 @@
 
 namespace Espo\Controllers;
 
+use Espo\Core\Exceptions\Error;
 use Espo\Core\{
     Controllers\Record,
     Api\Request,

application/Espo/Controllers/TwoFactorEmail.php

@@ -42,6 +42,8 @@ class TwoFactorEmail
 {
     private $service;
 
+    private $user;
+
     public function __construct(Service $service, User $user)
     {
         $this->service = $service;

application/Espo/Controllers/TwoFactorSms.php

@@ -42,6 +42,8 @@ class TwoFactorSms
 {
     private $service;
 
+    private $user;
+
     public function __construct(Service $service, User $user)
     {
         $this->service = $service;

application/Espo/Controllers/UserSecurity.php

@@ -44,6 +44,8 @@ class UserSecurity
 {
     private $service;
 
+    private $user;
+
     public function __construct(Service $service, User $user)
     {
         $this->service = $service;

application/Espo/Core/ApplicationState.php

@@ -29,6 +29,7 @@
 
 namespace Espo\Core;
 
+use Espo\Core\Exceptions\Error;
 use Espo\Entities\Portal as PortalEntity;
 use Espo\Entities\User as UserEntity;
 

application/Espo/Core/Authentication/Authentication.php

@@ -86,6 +86,8 @@ class Authentication
 
     private $twoFactorLoginFactory;
 
+    private $authTokenManager;
+
     private $hookManager;
 
     private $log;

application/Espo/Core/Authentication/Result/Data.php

@@ -43,6 +43,8 @@ class Data
 
     private $loggedUser = null;
 
+    private $status = null;
+
     private $failReason = null;
 
     private $data = [];

application/Espo/Core/Container.php

@@ -52,6 +52,8 @@ class Container implements ContainerInterface
 
     private $configuration = null;
 
+    private $bindingContainer;
+
     private $injectableFactory;
 
     public function __construct(

application/Espo/Core/FieldValidation/ValidatorFactory.php

@@ -68,7 +68,7 @@ class ValidatorFactory
         $className = $this->getClassName($entityType, $field);
 
         if (!$className) {
-            throw RuntimeException("Validator for '{$entityType}.{$field}' does not exist.");
+            throw new RuntimeException("Validator for '{$entityType}.{$field}' does not exist.");
         }
 
         return $this->injectableFactory->create($className);

application/Espo/Core/Formula/Evaluator.php

@@ -49,6 +49,8 @@ class Evaluator
 
     private $attributeFetcher;
 
+    private $injectableFactory;
+
     private $parsedHash;
 
     public function __construct(InjectableFactory $injectableFactory, array $functionClassNameMap = [])

application/Espo/Core/Formula/Functions/ValueType.php

@@ -41,7 +41,7 @@ class ValueType extends BaseFunction
     public function process(ArgumentList $args)
     {
         if (!count($args)) {
-            throw Error("Bad value.");
+            throw new Error("Bad value.");
         }
 
         $value = $args[0]->getData();

application/Espo/Core/Formula/Functions/VariableType.php

@@ -41,7 +41,7 @@ class VariableType extends BaseFunction
     public function process(ArgumentList $args)
     {
         if (!count($args)) {
-            throw Error("No variable name.");
+            throw new Error("No variable name.");
         }
 
         $name = $args[0]->getData();

application/Espo/Core/Htmlizer/Htmlizer.php

@@ -65,6 +65,8 @@ class Htmlizer
 
     private $dateTime;
 
+    private $number;
+
     private $config;
 
     private $acl;

application/Espo/Core/Mail/MessageWrapper.php

@@ -35,6 +35,8 @@ use Espo\Core\Mail\Mail\Storage\Imap;
 
 class MessageWrapper
 {
+    private $parser;
+
     private $storage;
 
     private $id;

application/Espo/Core/Select/SelectManagerFactory.php

@@ -53,6 +53,7 @@ class SelectManagerFactory
 
     private $user;
     private $acl;
+    private $aclManager;
     private $injectableFactory;
     private $classFinder;
 

application/Espo/Core/Select/Where/ItemGeneralConverter.php

@@ -355,7 +355,7 @@ class ItemGeneralConverter implements ItemConverter
             }
 
             if (!$arrayAttributeLink || !$arrayAttribute) {
-                throw Error("Bad where item.");
+                throw new Error("Bad where item.");
             }
 
             $arrayEntityType = $entityDefs->getRelation($arrayAttributeLink)->getForeignEntityType();

application/Espo/Core/Upgrades/Actions/Base/Delete.php

@@ -29,6 +29,8 @@
 
 namespace Espo\Core\Upgrades\Actions\Base;
 
+use Espo\Core\Exceptions\Error;
+
 class Delete extends \Espo\Core\Upgrades\Actions\Base
 {
     public function run($data)

application/Espo/Core/Utils/Database/Orm/RelationManager.php

@@ -37,6 +37,8 @@ class RelationManager
 {
     private $metadata;
 
+    private $config;
+
     public function __construct(Metadata $metadata, Config $config)
     {
         $this->metadata = $metadata;

application/Espo/Core/WebSocket/Submission.php

@@ -32,6 +32,7 @@ namespace Espo\Core\WebSocket;
 use Espo\Core\Utils\Log;
 
 use stdClass;
+use Throwable;
 
 class Submission
 {

application/Espo/Modules/Crm/Controllers/CaseObj.php

@@ -29,6 +29,9 @@
 
 namespace Espo\Modules\Crm\Controllers;
 
+use Espo\Core\Exceptions\Forbidden;
+use Espo\Core\Exceptions\BadRequest;
+
 class CaseObj extends \Espo\Core\Controllers\Record
 {
     protected $name = 'Case';

application/Espo/Modules/Crm/Controllers/KnowledgeBaseArticle.php

@@ -29,6 +29,8 @@
 
 namespace Espo\Modules\Crm\Controllers;
 
+use Espo\Core\Exceptions\BadRequest;
+
 class KnowledgeBaseArticle extends \Espo\Core\Controllers\Record
 {
     public function postActionGetCopiedAttachments($params, $data, $request)

application/Espo/Modules/Crm/Controllers/Lead.php

@@ -30,6 +30,7 @@
 namespace Espo\Modules\Crm\Controllers;
 
 use Espo\Core\Exceptions\BadRequest;
+use Espo\Core\Exceptions\Error;
 
 class Lead extends \Espo\Core\Controllers\Record
 {

application/Espo/Modules/Crm/Controllers/Target.php

@@ -30,6 +30,7 @@
 namespace Espo\Modules\Crm\Controllers;
 
 use Espo\Core\Exceptions\BadRequest;
+use Espo\Core\Exceptions\Error;
 
 class Target extends \Espo\Core\Controllers\Record
 {

application/Espo/Modules/Crm/Services/KnowledgeBaseArticle.php

@@ -29,6 +29,7 @@
 
 namespace Espo\Modules\Crm\Services;
 
+use Espo\Core\Exceptions\BadRequest;
 use Espo\Core\Exceptions\Forbidden;
 use Espo\Core\Exceptions\NotFound;
 use Espo\Core\Exceptions\Error;

application/Espo/Modules/Crm/Services/Meeting.php

@@ -34,6 +34,7 @@ use Espo\Modules\Crm\Business\Event\Invitations;
 
 use Espo\Services\Email as EmailService;
 
+use Espo\Core\Exceptions\NotFound;
 use Espo\Core\Exceptions\BadRequest;
 
 use Espo\Core\Di;

application/Espo/Modules/Crm/Services/TargetList.php

@@ -36,6 +36,7 @@ use Espo\ORM\Query\Select;
 use Espo\Core\Exceptions\NotFound;
 use Espo\Core\Exceptions\BadRequest;
 use Espo\Core\Exceptions\Forbidden;
+use Espo\Core\Exceptions\Error;
 
 use Espo\Core\{
     Record\Collection as RecordCollection,

application/Espo/ORM/Query/DeleteBuilder.php

@@ -29,6 +29,8 @@
 
 namespace Espo\ORM\Query;
 
+use RuntimeException;
+
 class DeleteBuilder implements Builder
 {
     use SelectingBuilderTrait;

application/Espo/ORM/QueryComposer/MysqlQueryComposer.php

@@ -32,6 +32,7 @@ namespace Espo\ORM\QueryComposer;
 use Espo\ORM\{
     Query\LockTable as LockTableQuery,
 };
+use LogicException;
 
 class MysqlQueryComposer extends BaseQueryComposer
 {

application/Espo/Repositories/Preferences.php

@@ -49,6 +49,8 @@ class Preferences implements Repository,
     use Di\ConfigSetter;
     use Di\EntityManagerSetter;
 
+    protected $entityFactory;
+
     public function __construct(
         EntityManager $entityManager,
         EntityFactory $entityFactory

application/Espo/Services/ExternalAccount.php

@@ -36,6 +36,7 @@ use Espo\Core\ExternalAccount\ClientManager;
 
 use Espo\Core\Exceptions\Error;
 use Espo\Core\Exceptions\NotFound;
+use Espo\Core\Exceptions\NotFoundSilent;
 use Espo\Core\Exceptions\Forbidden;
 
 use Espo\Core\Record\ReadParams;

application/Espo/Services/LeadCapture.php

@@ -35,6 +35,7 @@ use Espo\{
 };
 
 use Espo\Core\{
+    Exceptions\Forbidden,
     Exceptions\NotFound,
     Exceptions\Error,
     Utils\Util,

application/Espo/Services/RecordTree.php

@@ -35,6 +35,7 @@ use Espo\ORM\{
 };
 
 use Espo\Core\{
+    Exceptions\NotFound,
     Exceptions\Error,
     Exceptions\Forbidden,
     Select\SearchParams,

application/Espo/Services/Stream.php

@@ -104,6 +104,8 @@ class Stream
 
     private $selectBuilderFactory;
 
+    private $userAclManagerProvider;
+
     private $noteAccessControl;
 
     private $recordServiceContainer;

application/Espo/Tools/FieldManager/FieldManager.php

@@ -30,6 +30,7 @@
 namespace Espo\Tools\FieldManager;
 
 use Espo\Core\{
+    Exceptions\BadRequest,
     Exceptions\Error,
     Exceptions\Conflict,
     Container,

application/Espo/Tools/Import/Import.php

@@ -94,6 +94,8 @@ class Import
 
     private $jobSchedulerFactory;
 
+    private $recordServiceContainer;
+
     private $log;
 
     public function __construct(

application/Espo/Tools/Pdf/PrinterController.php

@@ -48,6 +48,8 @@ class PrinterController
 
     private $injectableFactory;
 
+    private $engine;
+
     public function __construct(
         Metadata $metadata,
         InjectableFactory $injectableFactory,