fix(attachments): bind upload to Note.attachments to satisfy EspoCRM

The EspoCRM tenant now rejects role=Attachment uploads that carry
neither `field` nor `parentType` (400 "No `field` and `parentType`."),
which broke the entire save-attachments flow on v1.2.13 — every file,
including PDFs, failed at Step 1.

Bind the upload to the documented Attachment-Multiple example
parentType=Note, field=attachments. Note.attachments is a built-in
field with no allowed-file-types restriction, so all types pass
(including images) — unlike Document.file, which rejected images with
403. No parentId is set; the blob stays standalone and is still just
pushed to the network share.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

src/OutlookAddin.Core/Services/EspoCrmClient.cs

@@ -213,13 +213,29 @@ namespace MarcusLaw.OutlookAddin.Core.Services
             // is sent in the "file" field as a data-URI. The previous extra
             // "contents" alias was an undocumented legacy that strict tenants
             // reject with 400.
+            //
+            // We bind the upload to Note.attachments (parentType=Note,
+            // field=attachments). EspoCRM's attachment access checker now
+            // REJECTS a role=Attachment upload that carries neither `field`
+            // nor `parentType` ("No `field` and `parentType`." → 400) — the
+            // earlier "unbound blob" shape no longer passes. Note.attachments
+            // is the documented Attachment-Multiple example and a built-in
+            // field that carries NO "allowed file types" restriction, so every
+            // file type (PDF, JPEG, PNG, …) passes — unlike Document.file,
+            // which Marcus-Law limits to PDF/Word and which rejected images
+            // with 403 "Not allowed file type".
+            //
+            // We never set parentId / create a Note: the attachment stays a
+            // standalone blob whose id we immediately push to the network
+            // share. The (parentType, field) pair only satisfies the access
+            // checker and selects an unrestricted file-type policy.
             var payload = new Dictionary<string, object?>
             {
                 ["name"] = fileName,
                 ["type"] = mime,
                 ["role"] = "Attachment",
-                ["relatedType"] = "Document",
-                ["field"] = "file",
+                ["parentType"] = "Note",
+                ["field"] = "attachments",
                 ["file"] = dataUri
             };
 

src/OutlookAddin.UI/ViewModels/SaveAttachmentsViewModel.cs

@@ -107,6 +107,38 @@ namespace MarcusLaw.OutlookAddin.UI.ViewModels
             }
         }
 
+        /// <summary>
+        /// Seeds the case list with the cases already resolved for the mail's
+        /// sender (from the sidebar match) so the user doesn't have to search
+        /// for a client we've already identified. When exactly one case is
+        /// known we auto-select it (which kicks the subfolder/folder-path
+        /// resolve); with several we just show them and let the user pick.
+        /// The user can still type in the search box to override — that
+        /// repopulates <see cref="Cases"/> from a fresh server search.
+        /// </summary>
+        public void PreselectCases(IReadOnlyList<CaseEntity> cases)
+        {
+            if (cases == null || cases.Count == 0) return;
+
+            Cases.Clear();
+            foreach (var c in cases)
+            {
+                if (c == null || string.IsNullOrEmpty(c.Id)) continue;
+                Cases.Add(c);
+            }
+            if (Cases.Count == 0) return;
+
+            if (Cases.Count == 1)
+            {
+                SelectedCase = Cases[0];
+                StatusMessage = "התיק זוהה אוטומטית מהשולח";
+            }
+            else
+            {
+                StatusMessage = $"{Cases.Count} תיקים מקושרים לשולח — בחר/י תיק";
+            }
+        }
+
         private void ResetSubfolders()
         {
             Subfolders.Clear();

src/OutlookAddin/OutlookAddin.csproj

@@ -257,6 +257,9 @@
     <EmbeddedResource Include="Ribbon\InspectorRibbon.xml">
       <LogicalName>OutlookAddin.Ribbon.InspectorRibbon.xml</LogicalName>
     </EmbeddedResource>
+    <EmbeddedResource Include="Ribbon\ReadMailRibbon.xml">
+      <LogicalName>OutlookAddin.Ribbon.ReadMailRibbon.xml</LogicalName>
+    </EmbeddedResource>
     <EmbeddedResource Include="Images\klear-file.png">
       <LogicalName>OutlookAddin.Images.klear-file.png</LogicalName>
     </EmbeddedResource>

src/OutlookAddin/Properties/AssemblyInfo.cs

@@ -33,6 +33,6 @@ using System.Security;
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("1.2.12.0")]
-[assembly: AssemblyFileVersion("1.2.12.0")]
+[assembly: AssemblyVersion("1.2.14.0")]
+[assembly: AssemblyFileVersion("1.2.14.0")]
 

src/OutlookAddin/Ribbon/ExplorerRibbon.cs

@@ -19,6 +19,7 @@ namespace OutlookAddin.Ribbon
     {
         private const string ExplorerResource = "OutlookAddin.Ribbon.ExplorerRibbon.xml";
         private const string InspectorResource = "OutlookAddin.Ribbon.InspectorRibbon.xml";
+        private const string ReadMailResource = "OutlookAddin.Ribbon.ReadMailRibbon.xml";
 
         // Every button whose `getEnabled` depends on the current Explorer
         // selection must be re-evaluated on every SelectionChange — Office
@@ -40,6 +41,8 @@ namespace OutlookAddin.Ribbon
                     return LoadResource(ExplorerResource);
                 case "Microsoft.Outlook.Mail.Compose":
                     return LoadResource(InspectorResource);
+                case "Microsoft.Outlook.Mail.Read":
+                    return LoadResource(ReadMailResource);
                 default:
                     return string.Empty;
             }
@@ -77,6 +80,51 @@ namespace OutlookAddin.Ribbon
             _inspectorRibbon = ribbon;
         }
 
+        // The read-mail inspector ribbon loads fresh for each opened message,
+        // so its getEnabled callback re-runs per window — no cached IRibbonUI
+        // or invalidation is needed here.
+        public void OnReadMailRibbonLoad(IRibbonUI ribbon)
+        {
+        }
+
+        /// <summary>
+        /// Enabled when the message open in this read inspector has at least
+        /// one attachment. Mirrors <see cref="OnGetSaveAttachmentsEnabled"/>
+        /// but reads the item from the Inspector context rather than the
+        /// Explorer selection.
+        /// </summary>
+        public bool OnGetSaveAttachmentsInspectorEnabled(IRibbonControl control)
+        {
+            try
+            {
+                var inspector = control?.Context as Outlook.Inspector;
+                if (inspector?.CurrentItem is not Outlook.MailItem mail) return false;
+                var attachments = mail.Attachments;
+                if (attachments == null) return false;
+                return attachments.Count > 0;
+            }
+            catch
+            {
+                return false;
+            }
+        }
+
+        public void OnSaveAttachmentsFromInspector(IRibbonControl control)
+        {
+            try
+            {
+                var inspector = control?.Context as Outlook.Inspector;
+                if (inspector?.CurrentItem is Outlook.MailItem mail)
+                {
+                    _ = Globals.ThisAddIn.AddInHost.LaunchSaveAttachmentsAsync(mail);
+                }
+            }
+            catch (Exception ex)
+            {
+                Globals.ThisAddIn.AddInHost.Logger.Warning(ex, "OnSaveAttachmentsFromInspector failed");
+            }
+        }
+
         public bool OnGetFileToEspoCrmEnabled(IRibbonControl control)
         {
             try
@@ -206,6 +254,7 @@ namespace OutlookAddin.Ribbon
                 {
                     case "FileToEspoCrm":        fileName = "klear-file.png";     break;
                     case "SaveAttachments":      fileName = "klear-attach.png";   break;
+                    case "SaveAttachmentsRead":  fileName = "klear-attach.png";   break;
                     case "ShowSidebar":          fileName = "klear-sidebar.png";  break;
                     case "OpenEspoCrmSettings":  fileName = "klear-settings.png"; break;
                     case "ComposeFromCase":      fileName = "klear-compose.png";  break;

src/OutlookAddin/Ribbon/ReadMailRibbon.xml

@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<customUI xmlns="http://schemas.microsoft.com/office/2009/07/customui" onLoad="OnReadMailRibbonLoad">
+  <ribbon>
+    <tabs>
+      <tab idMso="TabReadMessage">
+        <group id="MarcusLawReadGroup" label="Klear">
+          <button id="SaveAttachmentsRead"
+                  label="שמור קבצים"
+                  screentip="שמור את הקבצים המצורפים בלבד"
+                  supertip="מעלה את הקבצים המצורפים של המייל הזה ל-Klear כ-Documents מקושרים לתיק שתבחר, בלי לתייק את המייל עצמו."
+                  size="large"
+                  getImage="OnGetImage"
+                  onAction="OnSaveAttachmentsFromInspector"
+                  getEnabled="OnGetSaveAttachmentsInspectorEnabled" />
+        </group>
+      </tab>
+    </tabs>
+  </ribbon>
+</customUI>

src/OutlookAddin/Services/AddInHost.cs

@@ -485,6 +485,13 @@ namespace OutlookAddin.Services
             // Subfolders are populated lazily once the user picks a case;
             // the default static set is already pre-loaded.
 
+            // If the sender already maps to a known client, seed the case
+            // list so the user sees the identified case pre-selected instead
+            // of having to search. Uses the same matching lookup the sidebar
+            // does (cached for 10 min), so this is normally instant. Any
+            // failure here is non-fatal — the dialog still opens empty.
+            await TryPreselectSenderCaseAsync(vm, envelope.From).ConfigureAwait(true);
+
             var dialog = new SaveAttachmentsDialog(vm);
             AttachOwnerToOutlook(dialog);
             var ok = dialog.ShowDialog();
@@ -541,6 +548,30 @@ namespace OutlookAddin.Services
             }
         }
 
+        /// <summary>
+        /// Looks up the mail sender against the CRM (reusing the sidebar's
+        /// cached match) and, when it resolves to one or more linked cases,
+        /// seeds the save-attachments dialog so the already-identified client
+        /// case shows up pre-selected. Best-effort: swallows any error.
+        /// </summary>
+        private async Task TryPreselectSenderCaseAsync(SaveAttachmentsViewModel vm, string? senderEmail)
+        {
+            if (MatchingService == null || string.IsNullOrWhiteSpace(senderEmail)) return;
+            try
+            {
+                var match = await MatchingService.LookupAsync(senderEmail!).ConfigureAwait(true);
+                // Ambiguous (same email on several contacts) → don't guess; let
+                // the user search. A clean match with linked cases → seed them.
+                if (match == null || match.IsAmbiguous) return;
+                if (match.RecentCases == null || match.RecentCases.Count == 0) return;
+                vm.PreselectCases(match.RecentCases);
+            }
+            catch (Exception ex)
+            {
+                Logger.Warning(ex, "Sender-case preselect for save-attachments failed (non-fatal)");
+            }
+        }
+
         private static void ShowAttachmentSummary(AttachmentSaveSummary summary, string caseLabel, string targetPath)
         {
             string message;