Compare commits

...

14 Commits

Author SHA1 Message Date
PointStar be5edc203c feat: in-app updater button + correct case-folder resolution
Two related improvements:

1. About tab → "בדוק עדכונים" button. Calls ClickOnce's
   ApplicationDeployment.CurrentDeployment.CheckForDetailedUpdate +
   Update on background threads, so the user can pull a new release
   immediately without leaving Outlook — no PowerShell, no
   CleanOnlineAppCache dance.

   Status messages cover the four real outcomes:
     • not deployed via ClickOnce (F5 / dev install) → explicit error
     • on the latest version → green "already up to date"
     • update available → progress text, then "installed — restart
       Outlook"
     • download / manifest / generic exception → red, with reason

2. Case folder resolution now matches the server. The previous client
   logic used Case.name (the lawsuit title, e.g. "מונאס אריאל נ' ביטוח
   לאומי") which produced "47-מונאס אריאל נ ביטוח לאומי". But
   NetworkStorageIntegration's buildEntityFolderName uses the primary
   contact's name from Case.contactsIds[0] → server actually creates
   "47-אריאל מונאס" for the same case, so the two diverged and our
   uploads went to a phantom folder.

   New flow on case selection:
     a) EnsureCaseSubfoldersAsync (creates server's canonical folders)
     b) GetCase with select=contactsIds + networkStorageFolderPath
     c) GetContactAsync on contactsIds[0] → grab Name
     d) ResolveCaseFolderPath(case, contactName) → exact match
     e) Cache result on vm.ResolvedCaseFolderPath; AddInHost reads it
        instead of recomputing.

   ResolveCaseFolderPath fallback order is now (1) the integration's
   stored path, (2) <number>-<primary contact name>, (3) <number>-<case
   name>, (4) the contact / case name alone — matching the server's
   buildEntityFolderName logic step by step.

Tests: 39 passing.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-12 23:08:20 +03:00
PointStar 1788b5bbee fix(about): show real ClickOnce deployment version in Settings → About
The About tab was always showing "1.0.0" because it read the DLL's
AssemblyVersion, which we never bumped in source — even when the
ClickOnce manifest had been rolled to 1.1.0 by the CI tag.

Read System.Deployment.Application.ApplicationDeployment.CurrentDeployment
.CurrentVersion at runtime when the add-in is running under ClickOnce
(IsNetworkDeployed=true). That's the version the user actually
installed. Fall back to AssemblyVersion when dev-running under F5 (no
ClickOnce context). Adds System.Deployment GAC reference to the UI
project.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-12 22:59:19 +03:00
PointStar 8011d4e34c diag(attachments): post-upload "did the file actually arrive" check
The server reported successful uploads for the two PDFs into case 6a03166d…
("מונאס אריאל") but the user couldn't find the files on the share. Both
LocalFilesystemClient::uploadFile and WebDavClient::uploadFile return
true only on a real write, so something downstream is silently dropping
the payload — most likely a WebDAV proxy or a basePath mismatch
between what NetworkStorageIntegration thinks the storage is vs. what
the user is browsing.

Add a verification step right after the upload:

  1. POST /Attachment   →  attachmentId
  2. POST /NetworkStorage/action/upload  →  201 from server
  3. GET  /NetworkStorage/folderContents?path=<folder>
     • If our filename is in the listing → INF "verify present"
     • Else → WRN "expected X but NOT in listing. Currently in folder: […]"

The diagnostic line surfaces both halves of the puzzle in a single
log entry, so the next save attempt will tell us in plain text whether
the storage layer is the liar or the path is being normalised
somewhere unexpected.

Tests: 39 passing.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-12 22:58:12 +03:00
PointStar 5242abb585 feat(attachments): rewire to Marcus-Law NetworkStorageIntegration
After reading the NetworkStorageIntegration repo I realized the previous
"save attachments" flow was wrong on every level — Marcus-Law doesn't
use EspoCRM's stock Document/DocumentFolder model. Folders are real
filesystem paths under the network share, named after the Case (format
"<number>-<primary contact name>") with four standard subfolders:
מסמכים, אסמכתאות, התכתבויות, כללי.

Rewire the save pipeline against the integration's real endpoints
(documented in routes.json on the server repo):

Core — three new IEspoCrmClient methods:
- EnsureCaseSubfoldersAsync(caseId)
    POST /NetworkStorage/action/createSubfolders
    Idempotent — creates case folder + defaults if missing.
- ListNetworkStorageFolderAsync(path)
    GET /NetworkStorage/folderContents?path=…
    Returns folders + files; we filter to type=folder for the dropdown.
- UploadAttachmentToNetworkStorageAsync(attachmentId, targetPath)
    POST /NetworkStorage/action/upload
    Moves the staged Attachment binary onto the share at <path>/<name>.

CaseEntity gets a new `networkStorageFolderPath` field (set by the
integration's hook on first Document save; empty until then).

NetworkStorageItem DTO captures the folder-listing rows.

AttachmentSaveService rewritten — no more Document creation, no more
DocumentFolder picker. The new contract is:
    SaveAsync(attachments, targetFolderPath)
Where targetFolderPath = "<case folder>[/subfolder]". For each
attachment: upload binary via standard /Attachment, then move via
NetworkStorage upload.

UI — SaveAttachmentsViewModel:
- Subfolder dropdown switched from DocumentFolder objects to strings.
- Static defaults loaded up-front:
    "(שורש התיק)" + 4 server-side defaults.
- When the user picks a case:
    1) hydrate Case (number + networkStorageFolderPath) via GetCase
    2) call EnsureCaseSubfoldersAsync to materialise standard folders
    3) listFolder at the case path to merge any custom subfolders into
       the dropdown.
- ResolveCaseFolderPath: use Case.networkStorageFolderPath if set,
  otherwise compute "<number>-<contact-name>" with a client-side
  SanitizeFolderSegment that mirrors LocalFilesystemClient::sanitizeFileName
  on the server (geresh/gershayim/quotes removed, illegal chars → hyphen).

AddInHost.LaunchSaveAttachmentsAsync:
- Composes <caseFolder>[/subfolder] from the VM choice.
- Pre-flight ensureCaseSubfolders as a safety net (in case the user
  submitted before the dialog's lazy refresh completed).
- Summary MessageBox now shows the resolved storage path instead of a
  bare entity name.

Tests: 39 passing. The build is clean across Core / UI / Tests.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-12 21:42:22 +03:00
PointStar 037d573e6e log: ListDocumentFoldersAsync prints folder count on success
When the case-scoped query fails (e.g. tenant rejects parentId in
where), the ViewModel falls back to ListDocumentFoldersAsync — but a
success path with N=0 was silent, leaving the user wondering why the
dropdown stayed empty. Add an INF line so the log shows whether
N folders came back, so 0-folder tenants are obvious from a glance.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-12 21:22:10 +03:00
PointStar cb7d530b4c fix(attachments): map MIME from extension + don't treat 403 as auth
Two bugs found by reading the log carefully — both shipped in the
initial attachments feature:

1. MailItemExtractor sent every attachment with ContentType = "" and
   UploadAttachmentAsync defaulted that to "application/octet-stream".
   EspoCRM's attachment upload whitelist (config
   attachmentUpload.fileAcceptOptions) does not include octet-stream,
   so the server replied:
     403 (X-Status-Reason=Not allowed file type.)
   Add a GuessMimeType(fileName) helper to MailItemExtractor that maps
   common extensions (pdf, doc/docx, xls/xlsx, ppt/pptx, txt, csv,
   images, archives, email, audio/video) to canonical MIMEs. The
   octet-stream is now only used for truly unknown extensions.

2. 403 was being conflated with 401 in THREE places — EnsureSuccessAsync,
   the inline UploadAttachmentAsync handler, and the inline
   CreateDocumentAsync handler. Result: a single "Not allowed file
   type" rejection threw EspoCrmAuthorizationException, which
   AttachmentSaveService treats as a batch-level auth failure and
   stops processing remaining files. (Same bug would have killed
   FilingService and MatchingService for any non-auth 403 — e.g. an
   ACL miss on one record stopping a multi-mail file.)

   Only 401 is unambiguously an auth issue. 403 means "you ARE who
   you say you are, but this specific operation isn't allowed" —
   content rejected / ACL miss / role missing. Treat 403 as a normal
   HTTP error: log the body + X-Status-Reason and surface the message
   to the user without aborting the batch.

Also include the X-Status-Reason header in the generic
EspoCrmHttpException message everywhere, so any future "fileSizeTooBig"
or similar shows up in the user-visible error and not just the log.

Tests: 39 passing.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-12 21:12:08 +03:00
PointStar 7924cda520 fix(documents): set publishDate on Document create (Marcus-Law requires it)
The server returned:
  400 {"messageTranslation":{"label":"validationFailure",
       "data":{"field":"publishDate","type":"required"}}}

Marcus-Law's EspoCRM install marks Document.publishDate as required.
By default the field is optional, but this tenant tightened it. Send
today's date (UTC, YYYY-MM-DD form) so the validation passes — the
user can still edit the published date in EspoCRM later if needed.

Also add the same verbose-error pattern to CreateDocumentAsync that we
already use on UploadAttachmentAsync: when the create returns non-2xx,
log the response body + X-Status-Reason header so any future required-
field mismatch shows up as a single readable line instead of
"שמירת הקבצים נכשלה".

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-12 21:03:16 +03:00
PointStar 7ee9a00fc4 fix(attachments): match official EspoCRM API + folder fallback
Per the EspoCRM Attachment API doc (documentation.espocrm.com/development/api/attachment/),
the binary is sent in the "file" field as a data URI. The previous
extra "contents" alias was a legacy convention that strict tenants
reject with HTTP 400 (with an empty body, so the user only ever saw
"שמירת הקבצים נכשלה"). Drop "contents" — match the documented payload:

  {
    "name": "report.pdf",
    "type": "application/pdf",
    "role": "Attachment",
    "relatedType": "Document",
    "field": "file",
    "file": "data:application/pdf;base64,..."
  }

Folder dropdown: previously case-scoped only. The /Document filter by
parentId returned 400 on this tenant and case-scoped queries can be
fragile across versions. Now: try case-scoped first (so the most-
relevant folders surface); if it comes back empty or errors, fall back
to ListDocumentFoldersAsync (the full tenant list). The user always has
something to choose from, and the "(בלי תיקייה)" sentinel still works
as a "no folder" pick.

Tests: 39 passing.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-12 20:51:46 +03:00
PointStar af8cf13443 fix(attachments): folder query + verbose upload diagnostics
Two fixes for the save-attachments flow:

1. ListFoldersUsedInCaseAsync no longer hits /Case/{id}/documents — that
   related-records endpoint requires a Case-to-Document link that
   EspoCRM doesn't ship by default, so it returned an empty list on
   every install. Switch to a direct Document list filtered by the
   polymorphic parent fields:
     GET /Document?where[0]=parentType=Case&where[1]=parentId=<id>
   That returns all documents linked to the case regardless of how the
   parent relationship is wired.

2. UploadAttachmentAsync now:
   - Emits BOTH "contents" and "file" payload fields with the
     data-URI base64 string. Different EspoCRM versions read from
     different keys; including both makes the call portable.
   - Logs the request shape (name, type, base64 length) before sending
     so server-side rejects are easier to attribute.
   - On a non-2xx response, logs the response body AND any
     X-Status-Reason header (EspoCRM convention for short error codes
     like "fileSizeIsTooLarge") so the user-visible exception finally
     includes a useful reason instead of an empty body.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-12 20:42:38 +03:00
PointStar 26322c92ff feat(save-attachments): scope folder list to the selected case
The folder dropdown was showing every DocumentFolder in EspoCRM (global
list). The user expected "folders that exist in THIS case" — only the
folders already in use for the chosen case's documents.

Change: when the user picks a case in the SaveAttachments dialog, the
folder list refreshes by walking
  GET /Case/{id}/documents?select=id,folderId,folderName&maxSize=200
and deduping the folderId values it finds. EspoCRM denormalizes
folderName onto Document, so no second lookup is needed.

If a case has no documents yet, the dropdown shows just the sentinel
"(בלי תיקייה)" — same default behavior as before, but no more
unrelated folders from other cases.

Files:
- Core: DocumentEntity gets FolderName; IEspoCrmClient and EspoCrmClient
  get ListFoldersUsedInCaseAsync(caseId)
- UI: SaveAttachmentsViewModel re-fetches on SelectedCase change
  (LoadFoldersForCaseAsync); AddInHost no longer calls the old
  LoadFoldersAsync.

Tests: 39 still passing.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-12 20:32:55 +03:00
PointStar c98fee7b5b fix(csproj): re-add klear-attach.png embed entry (VS save stripped it)
Visual Studio rewrote the legacy VSTO csproj on its next save and
dropped the EmbeddedResource entry for the paperclip icon — without
it the new SaveAttachments ribbon button has no image at runtime and
the file isn't shipped in the assembly. Add it back next to the four
other Klear icons.
2026-05-12 20:28:19 +03:00
PointStar 1a9ca2d2ad fix(ribbon): invalidate "שמור קבצים" on SelectionChange (button stays disabled)
The new SaveAttachments button rendered but stayed greyed out. Cause:
getEnabled callbacks are evaluated once when the ribbon loads and the
result is cached — Office only re-asks if you explicitly invalidate
the control. The previous SelectionChange handler invalidated only
FileToEspoCrm.

Collected the selection-dependent button IDs into a static array and
made the SelectionChange handler invalidate all of them. Adding more
context-sensitive buttons in the future is now a one-line edit.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-12 20:27:33 +03:00
PointStar b1f8e3e50b feat(attachments): "save attachments only" ribbon action
New workflow alongside "תייק ל-Klear": save just the attachments of a
mail to a Case in EspoCRM (no Email entity created), with an optional
DocumentFolder.

Core:
- AttachmentEntity, DocumentEntity, DocumentFolder DTOs
- IEspoCrmClient gets three new endpoints:
    UploadAttachmentAsync (POST /Attachment, data-URI base64, role=Attachment)
    CreateDocumentAsync   (POST /Document, fileId + parent + folderId)
    ListDocumentFoldersAsync (GET /DocumentFolder, returns envelope)
- AttachmentSaveService orchestrates per-attachment upload + Document
  create, short-circuits on EspoCrmAuthorizationException, aggregates
  per-file Saved/Failed/AuthRequired outcomes into AttachmentSaveSummary

UI:
- SaveAttachmentsDialog (RTL, card layout matching FileToCaseDialog):
  Case search + folder dropdown + per-attachment checkbox list
- SaveAttachmentsViewModel: debounced GlobalSearch filtered to Case,
  optional folder selector (with a "(no folder)" sentinel row),
  Attachments collection of AttachmentRowViewModel rows
- AttachmentRowViewModel: IsSelected checkbox + display name + size
  computed from base64 length

Host:
- AddInHost.LaunchSaveAttachmentsAsync(MailItem) — extracts on the STA
  via MailItemExtractor, fetches folders, shows the dialog (anchored to
  Outlook via AttachOwnerToOutlook), runs AttachmentSaveService on OK,
  reports a Hebrew MessageBox summary
- AttachmentSaveService field on AddInHost + dispose hook

Ribbon:
- New "שמור קבצים" button in the Marcus-Law group, between Klear and
  פרטי תיק. Enabled only when exactly one MailItem is selected and it
  has at least one attachment
- klear-attach.png paperclip icon (32x32, blue rounded square),
  embedded as a resource and resolved by the existing OnGetImage
  callback (new case in the switch)

Tests: 39 still passing.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-12 20:12:46 +03:00
chaim 0fea393b81 dist: add packaged OutlookAddin-Install.zip for end-user distribution
Contains:
- Install-Marcus-Law-OutlookAddin.bat (self-elevating UAC launcher)
- 4-install-addin-full.ps1            (cert + VSTOInstaller all-in-one)
- codesign.cer                        (public Marcus-Law CodeSign cert)

Lawyers download the zip, extract, and double-click the .bat.
2026-05-11 18:06:52 +00:00
23 changed files with 1657 additions and 9 deletions
BIN
View File
Binary file not shown.
@@ -0,0 +1,20 @@
using System.Text.Json.Serialization;
namespace MarcusLaw.OutlookAddin.Core.Models
{
/// <summary>
/// Response from POST /api/v1/Attachment — the server returns at least
/// the new attachment's id, which we then thread into a Document create.
/// </summary>
public sealed class AttachmentEntity
{
[JsonPropertyName("id")]
public string Id { get; set; } = string.Empty;
[JsonPropertyName("name")]
public string? Name { get; set; }
[JsonPropertyName("type")]
public string? Type { get; set; }
}
}
@@ -31,5 +31,12 @@ namespace MarcusLaw.OutlookAddin.Core.Models
[JsonPropertyName("createdAt")]
public DateTimeOffset? CreatedAt { get; set; }
// Set by Marcus-Law's NetworkStorageIntegration hook on first
// Document save. Empty until a document has been written through
// EspoCRM. When empty we compute it client-side from number +
// primary contact name.
[JsonPropertyName("networkStorageFolderPath")]
public string? NetworkStorageFolderPath { get; set; }
}
}
@@ -0,0 +1,31 @@
using System.Text.Json.Serialization;
namespace MarcusLaw.OutlookAddin.Core.Models
{
public sealed class DocumentEntity
{
[JsonPropertyName("id")]
public string Id { get; set; } = string.Empty;
[JsonPropertyName("name")]
public string? Name { get; set; }
[JsonPropertyName("status")]
public string? Status { get; set; }
[JsonPropertyName("fileId")]
public string? FileId { get; set; }
[JsonPropertyName("folderId")]
public string? FolderId { get; set; }
[JsonPropertyName("folderName")]
public string? FolderName { get; set; }
[JsonPropertyName("parentType")]
public string? ParentType { get; set; }
[JsonPropertyName("parentId")]
public string? ParentId { get; set; }
}
}
@@ -0,0 +1,24 @@
using System.Text.Json.Serialization;
namespace MarcusLaw.OutlookAddin.Core.Models
{
/// <summary>
/// A row from /api/v1/DocumentFolder — used to populate the folder
/// dropdown in the "Save attachments" dialog. EspoCRM document folders
/// are organizational labels independent of the document's parent link.
/// </summary>
public sealed class DocumentFolder
{
[JsonPropertyName("id")]
public string Id { get; set; } = string.Empty;
[JsonPropertyName("name")]
public string? Name { get; set; }
[JsonPropertyName("parentId")]
public string? ParentId { get; set; }
[JsonPropertyName("order")]
public int? Order { get; set; }
}
}
@@ -0,0 +1,27 @@
using System.Text.Json.Serialization;
namespace MarcusLaw.OutlookAddin.Core.Models
{
/// <summary>
/// One row from GET /NetworkStorage/folderContents — folder or file.
/// </summary>
public sealed class NetworkStorageItem
{
[JsonPropertyName("name")]
public string Name { get; set; } = string.Empty;
[JsonPropertyName("path")]
public string Path { get; set; } = string.Empty;
[JsonPropertyName("type")]
public string Type { get; set; } = string.Empty; // "folder" or "file"
[JsonPropertyName("size")]
public long Size { get; set; }
[JsonPropertyName("modified")]
public string? Modified { get; set; }
public bool IsFolder => string.Equals(Type, "folder", System.StringComparison.OrdinalIgnoreCase);
}
}
@@ -0,0 +1,158 @@
using System;
using System.Collections.Generic;
using System.Threading;
using System.Threading.Tasks;
using MarcusLaw.OutlookAddin.Core.Models;
using Serilog;
namespace MarcusLaw.OutlookAddin.Core.Services
{
public sealed class AttachmentSaveService : IAttachmentSaveService
{
private readonly IEspoCrmClient _client;
private readonly ILogger _logger;
public AttachmentSaveService(IEspoCrmClient client, ILogger logger)
{
_client = client ?? throw new ArgumentNullException(nameof(client));
_logger = logger ?? throw new ArgumentNullException(nameof(logger));
}
public async Task<AttachmentSaveSummary> SaveAsync(
IReadOnlyList<EspoAttachment> attachments,
string targetFolderPath,
CancellationToken cancellationToken = default)
{
if (attachments == null) throw new ArgumentNullException(nameof(attachments));
if (string.IsNullOrWhiteSpace(targetFolderPath)) throw new ArgumentException("targetFolderPath required", nameof(targetFolderPath));
var summary = new AttachmentSaveSummary();
if (attachments.Count == 0) return summary;
var trimmedFolder = targetFolderPath.TrimEnd('/');
foreach (var att in attachments)
{
cancellationToken.ThrowIfCancellationRequested();
if (summary.AuthRequired)
{
summary.Items.Add(new AttachmentSaveItemResult
{
FileName = att.Name,
Outcome = AttachmentSaveOutcome.AuthRequired,
ErrorMessage = "Skipped — earlier upload rejected by EspoCRM"
});
continue;
}
try
{
// Step 1: create the EspoCRM Attachment (binary stored
// in data/upload/<id>; not yet on the network share).
var uploaded = await _client.UploadAttachmentAsync(
att.Name, att.ContentType, att.ContentBase64, cancellationToken).ConfigureAwait(false);
// Step 2: ask Marcus-Law's NetworkStorageIntegration
// to place the uploaded blob under <targetFolderPath>.
// The integration appends the filename to the path.
await _client.UploadAttachmentToNetworkStorageAsync(
uploaded.Id, trimmedFolder, cancellationToken).ConfigureAwait(false);
// Step 3: verify the file actually landed on the share —
// the server can return 200 yet leave nothing on disk
// when a downstream WebDAV proxy silently fails. Read
// the folder back and look for our filename.
await VerifyArrivedAsync(att.Name, trimmedFolder, cancellationToken).ConfigureAwait(false);
_logger.Information(
"Saved attachment {Name} → {Path} (attachmentId={AttachmentId})",
att.Name, trimmedFolder, uploaded.Id);
summary.Items.Add(new AttachmentSaveItemResult
{
FileName = att.Name,
Outcome = AttachmentSaveOutcome.Saved,
AttachmentId = uploaded.Id
});
}
catch (EspoCrmAuthorizationException ex)
{
_logger.Warning(ex, "Attachment save aborted: EspoCRM rejected credentials");
summary.AuthRequired = true;
summary.Items.Add(new AttachmentSaveItemResult
{
FileName = att.Name,
Outcome = AttachmentSaveOutcome.AuthRequired,
ErrorMessage = ex.Message
});
}
catch (OperationCanceledException)
{
throw;
}
catch (Exception ex)
{
_logger.Warning(ex, "Attachment save failed for {Name}", att.Name);
summary.Items.Add(new AttachmentSaveItemResult
{
FileName = att.Name,
Outcome = AttachmentSaveOutcome.Failed,
ErrorMessage = ex.Message
});
}
}
return summary;
}
/// <summary>
/// Post-upload sanity check: list the folder we just wrote into
/// and confirm a file with the same (possibly sanitized) name
/// shows up. Diagnostic only — does not change the outcome. If
/// the file isn't there, log a WARNING with everything that IS
/// in the folder so we can spot the actual server-side path.
/// </summary>
private async Task VerifyArrivedAsync(string expectedName, string folderPath, CancellationToken ct)
{
try
{
var items = await _client.ListNetworkStorageFolderAsync(folderPath, ct).ConfigureAwait(false);
var trimmedExpected = expectedName.Trim().TrimStart('-', ' ').TrimEnd('-', ' ');
bool found = false;
foreach (var it in items)
{
if (it.IsFolder) continue;
if (string.Equals(it.Name, expectedName, StringComparison.Ordinal) ||
string.Equals(it.Name, trimmedExpected, StringComparison.Ordinal))
{
found = true;
break;
}
}
if (!found)
{
var names = new List<string>();
foreach (var it in items)
{
if (it.IsFolder) continue;
names.Add(it.Name);
}
_logger.Warning(
"Post-upload verify: expected '{Expected}' under '{Path}' but it's NOT in the listing. " +
"Server reported the upload as successful but the file is not on the share. " +
"Files currently in that folder: [{Files}]",
expectedName, folderPath, string.Join(", ", names));
}
else
{
_logger.Information("Post-upload verify: '{Expected}' present under '{Path}'", expectedName, folderPath);
}
}
catch (Exception ex)
{
_logger.Warning(ex, "Post-upload verify failed for '{Expected}' under '{Path}'", expectedName, folderPath);
}
}
}
}
+322 -2
View File
@@ -202,6 +202,320 @@ namespace MarcusLaw.OutlookAddin.Core.Services
public Task<UserInfo> TestConnectionAsync(CancellationToken cancellationToken = default)
=> GetJsonAsync<UserInfo>("App/user", cancellationToken);
public async Task<AttachmentEntity> UploadAttachmentAsync(string fileName, string contentType, string base64Content, CancellationToken cancellationToken = default)
{
if (string.IsNullOrWhiteSpace(fileName)) throw new ArgumentException("fileName required", nameof(fileName));
if (string.IsNullOrWhiteSpace(base64Content)) throw new ArgumentException("base64Content required", nameof(base64Content));
var mime = string.IsNullOrWhiteSpace(contentType) ? "application/octet-stream" : contentType;
var dataUri = "data:" + mime + ";base64," + base64Content;
// Per the official EspoCRM API docs (POST /Attachment), the binary
// is sent in the "file" field as a data-URI. The previous extra
// "contents" alias was an undocumented legacy that strict tenants
// reject with 400.
var payload = new Dictionary<string, object?>
{
["name"] = fileName,
["type"] = mime,
["role"] = "Attachment",
["relatedType"] = "Document",
["field"] = "file",
["file"] = dataUri
};
var json = JsonSerializer.Serialize(payload, JsonOptions);
_logger.Information(
"UploadAttachment POST /Attachment (name={Name}, type={Type}, base64Length={Length})",
fileName, mime, base64Content.Length);
var response = await ExecuteAsync(HttpMethod.Post, "Attachment", json, cancellationToken).ConfigureAwait(false);
try
{
if (!response.IsSuccessStatusCode)
{
var errBody = await ReadBodyAsync(response).ConfigureAwait(false);
var reason = string.Join(",", response.Headers.TryGetValues("X-Status-Reason", out var v) ? v : Array.Empty<string>());
_logger.Warning(
"UploadAttachment failed: {Status} (X-Status-Reason={Reason}) body={Body}",
response.StatusCode, reason, string.IsNullOrEmpty(errBody) ? "(empty)" : Truncate(errBody, 500));
// 401 only = auth. 403 here is content/permission, not creds.
if (response.StatusCode == HttpStatusCode.Unauthorized)
{
throw new EspoCrmAuthorizationException(
$"EspoCRM rejected credentials ({(int)response.StatusCode} {response.StatusCode}). Re-enter API key.");
}
throw new EspoCrmHttpException(response.StatusCode, errBody,
$"EspoCRM Attachment upload returned {(int)response.StatusCode} {response.StatusCode}" +
(string.IsNullOrEmpty(reason) ? "" : " (reason: " + reason + ")"));
}
var body = await ReadBodyAsync(response).ConfigureAwait(false);
return JsonSerializer.Deserialize<AttachmentEntity>(body, JsonOptions)
?? throw new EspoCrmHttpException(response.StatusCode, body, "Empty AttachmentEntity from EspoCRM");
}
finally
{
response.Dispose();
}
}
public async Task<DocumentEntity> CreateDocumentAsync(string name, string attachmentFileId, string? parentType, string? parentId, string? folderId, CancellationToken cancellationToken = default)
{
if (string.IsNullOrWhiteSpace(name)) throw new ArgumentException("name required", nameof(name));
if (string.IsNullOrWhiteSpace(attachmentFileId)) throw new ArgumentException("attachmentFileId required", nameof(attachmentFileId));
// Marcus-Law's EspoCRM has `publishDate` configured as required on
// Document. The field accepts a plain date (YYYY-MM-DD). Default
// to today; the user can edit it later in EspoCRM if needed.
var todayIso = DateTimeOffset.UtcNow.ToString("yyyy-MM-dd", System.Globalization.CultureInfo.InvariantCulture);
var payload = new Dictionary<string, object?>
{
["name"] = name,
["fileId"] = attachmentFileId,
["status"] = "Active",
["publishDate"] = todayIso
};
if (!string.IsNullOrWhiteSpace(parentType)) payload["parentType"] = parentType;
if (!string.IsNullOrWhiteSpace(parentId)) payload["parentId"] = parentId;
if (!string.IsNullOrWhiteSpace(folderId)) payload["folderId"] = folderId;
var json = JsonSerializer.Serialize(payload, JsonOptions);
_logger.Information(
"CreateDocument POST /Document (name={Name}, fileId={FileId}, parent={ParentType}/{ParentId}, folder={FolderId})",
name, attachmentFileId, parentType, parentId, folderId ?? "(none)");
var response = await ExecuteAsync(HttpMethod.Post, "Document", json, cancellationToken).ConfigureAwait(false);
try
{
if (!response.IsSuccessStatusCode)
{
var errBody = await ReadBodyAsync(response).ConfigureAwait(false);
var reason = response.Headers.TryGetValues("X-Status-Reason", out var v)
? string.Join(",", v) : "(none)";
_logger.Warning(
"CreateDocument failed: {Status} (X-Status-Reason={Reason}) body={Body}",
response.StatusCode, reason, string.IsNullOrEmpty(errBody) ? "(empty)" : Truncate(errBody, 500));
if (response.StatusCode == HttpStatusCode.Unauthorized)
{
throw new EspoCrmAuthorizationException(
$"EspoCRM rejected credentials ({(int)response.StatusCode} {response.StatusCode}). Re-enter API key.");
}
throw new EspoCrmHttpException(response.StatusCode, errBody,
$"EspoCRM Document create returned {(int)response.StatusCode} {response.StatusCode}" +
(string.IsNullOrEmpty(reason) ? "" : " (reason: " + reason + ")"));
}
var body = await ReadBodyAsync(response).ConfigureAwait(false);
return JsonSerializer.Deserialize<DocumentEntity>(body, JsonOptions)
?? throw new EspoCrmHttpException(response.StatusCode, body, "Empty DocumentEntity from EspoCRM");
}
finally
{
response.Dispose();
}
}
public async Task<List<DocumentFolder>> ListFoldersUsedInCaseAsync(string caseId, CancellationToken cancellationToken = default)
{
if (string.IsNullOrWhiteSpace(caseId)) return new List<DocumentFolder>();
// Some EspoCRM installs reject filtering by polymorphic parentType
// with a 400. ParentId is a regular string field, and an ID alone
// is unique enough — we'll filter just by that. We additionally
// verify parentType client-side to be safe.
var path =
"Document?select=" + Uri.EscapeDataString("id,folderId,folderName,parentType") +
"&where[0][type]=equals" +
"&where[0][attribute]=parentId" +
"&where[0][value]=" + Uri.EscapeDataString(caseId) +
"&maxSize=200";
// Hand-rolled error capture (instead of GetJsonAsync) so a 400 from
// a picky tenant ends up in the log with body + X-Status-Reason.
HttpResponseMessage? response = null;
try
{
response = await ExecuteAsync(HttpMethod.Get, path, null, cancellationToken).ConfigureAwait(false);
if (!response.IsSuccessStatusCode)
{
var errBody = await ReadBodyAsync(response).ConfigureAwait(false);
var reason = response.Headers.TryGetValues("X-Status-Reason", out var v)
? string.Join(",", v) : "(none)";
_logger.Warning(
"ListFoldersUsedInCase({CaseId}): {Status} (X-Status-Reason={Reason}) body={Body}",
caseId, response.StatusCode, reason,
string.IsNullOrEmpty(errBody) ? "(empty)" : Truncate(errBody, 500));
return new List<DocumentFolder>();
}
var body = await ReadBodyAsync(response).ConfigureAwait(false);
var parsed = JsonSerializer.Deserialize<EspoListResponse<DocumentEntity>>(body, JsonOptions)
?? new EspoListResponse<DocumentEntity>();
var seen = new HashSet<string>(StringComparer.Ordinal);
var folders = new List<DocumentFolder>();
foreach (var doc in parsed.List)
{
// Defensive: if the server returns docs from other parents
// (shouldn't, but ID collisions are theoretically possible),
// drop them.
if (!string.IsNullOrEmpty(doc.ParentType) &&
!string.Equals(doc.ParentType, "Case", StringComparison.OrdinalIgnoreCase))
{
continue;
}
if (string.IsNullOrEmpty(doc.FolderId)) continue;
if (!seen.Add(doc.FolderId!)) continue;
folders.Add(new DocumentFolder
{
Id = doc.FolderId!,
Name = string.IsNullOrWhiteSpace(doc.FolderName) ? doc.FolderId! : doc.FolderName!
});
}
_logger.Information(
"ListFoldersUsedInCase({CaseId}) → {DocumentCount} documents, {FolderCount} distinct folders",
caseId, parsed.List.Count, folders.Count);
return folders;
}
catch (Exception ex)
{
_logger.Warning(ex, "ListFoldersUsedInCaseAsync({CaseId}) failed", caseId);
return new List<DocumentFolder>();
}
finally
{
response?.Dispose();
}
}
public async Task EnsureCaseSubfoldersAsync(string caseId, CancellationToken cancellationToken = default)
{
if (string.IsNullOrWhiteSpace(caseId)) throw new ArgumentException("caseId required", nameof(caseId));
var payload = new Dictionary<string, object?>
{
["entityType"] = "Case",
["entityId"] = caseId
};
var json = JsonSerializer.Serialize(payload, JsonOptions);
var response = await ExecuteAsync(HttpMethod.Post, "NetworkStorage/action/createSubfolders", json, cancellationToken).ConfigureAwait(false);
try
{
if (!response.IsSuccessStatusCode)
{
var body = await ReadBodyAsync(response).ConfigureAwait(false);
var reason = response.Headers.TryGetValues("X-Status-Reason", out var v) ? string.Join(",", v) : "(none)";
_logger.Warning(
"EnsureCaseSubfolders({CaseId}): {Status} (X-Status-Reason={Reason}) body={Body}",
caseId, response.StatusCode, reason, string.IsNullOrEmpty(body) ? "(empty)" : Truncate(body, 500));
if (response.StatusCode == HttpStatusCode.Unauthorized)
{
throw new EspoCrmAuthorizationException("EspoCRM rejected credentials. Re-enter API key.");
}
// Don't throw — folder creation is best-effort. Upload will fail
// with its own clear error if the parent really isn't there.
return;
}
_logger.Information("EnsureCaseSubfolders({CaseId}) OK", caseId);
}
finally
{
response.Dispose();
}
}
public async Task<List<NetworkStorageItem>> ListNetworkStorageFolderAsync(string path, CancellationToken cancellationToken = default)
{
var query = "NetworkStorage/folderContents";
if (!string.IsNullOrEmpty(path))
{
query += "?path=" + Uri.EscapeDataString(path);
}
HttpResponseMessage? response = null;
try
{
response = await ExecuteAsync(HttpMethod.Get, query, null, cancellationToken).ConfigureAwait(false);
if (!response.IsSuccessStatusCode)
{
var body = await ReadBodyAsync(response).ConfigureAwait(false);
var reason = response.Headers.TryGetValues("X-Status-Reason", out var v) ? string.Join(",", v) : "(none)";
_logger.Warning(
"ListNetworkStorageFolder({Path}): {Status} (X-Status-Reason={Reason}) body={Body}",
path, response.StatusCode, reason, string.IsNullOrEmpty(body) ? "(empty)" : Truncate(body, 500));
return new List<NetworkStorageItem>();
}
var json = await ReadBodyAsync(response).ConfigureAwait(false);
var items = JsonSerializer.Deserialize<List<NetworkStorageItem>>(json, JsonOptions);
_logger.Information("ListNetworkStorageFolder({Path}) → {Count} entries", path, items?.Count ?? 0);
return items ?? new List<NetworkStorageItem>();
}
catch (Exception ex)
{
_logger.Warning(ex, "ListNetworkStorageFolderAsync({Path}) failed", path);
return new List<NetworkStorageItem>();
}
finally
{
response?.Dispose();
}
}
public async Task UploadAttachmentToNetworkStorageAsync(string attachmentId, string targetPath, CancellationToken cancellationToken = default)
{
if (string.IsNullOrWhiteSpace(attachmentId)) throw new ArgumentException("attachmentId required", nameof(attachmentId));
if (string.IsNullOrWhiteSpace(targetPath)) throw new ArgumentException("targetPath required", nameof(targetPath));
var payload = new Dictionary<string, object?>
{
["attachmentId"] = attachmentId,
["path"] = targetPath
};
var json = JsonSerializer.Serialize(payload, JsonOptions);
_logger.Information(
"UploadToNetworkStorage POST /NetworkStorage/action/upload (attachmentId={AttachmentId}, path={Path})",
attachmentId, targetPath);
var response = await ExecuteAsync(HttpMethod.Post, "NetworkStorage/action/upload", json, cancellationToken).ConfigureAwait(false);
try
{
if (!response.IsSuccessStatusCode)
{
var body = await ReadBodyAsync(response).ConfigureAwait(false);
var reason = response.Headers.TryGetValues("X-Status-Reason", out var v) ? string.Join(",", v) : "(none)";
_logger.Warning(
"UploadToNetworkStorage failed: {Status} (X-Status-Reason={Reason}) body={Body}",
response.StatusCode, reason, string.IsNullOrEmpty(body) ? "(empty)" : Truncate(body, 500));
if (response.StatusCode == HttpStatusCode.Unauthorized)
{
throw new EspoCrmAuthorizationException("EspoCRM rejected credentials. Re-enter API key.");
}
throw new EspoCrmHttpException(response.StatusCode, body,
$"NetworkStorage upload returned {(int)response.StatusCode} {response.StatusCode}" +
(string.IsNullOrEmpty(reason) || reason == "(none)" ? "" : " (reason: " + reason + ")"));
}
}
finally
{
response.Dispose();
}
}
public async Task<EspoListResponse<DocumentFolder>> ListDocumentFoldersAsync(CancellationToken cancellationToken = default)
{
try
{
var result = await GetJsonAsync<EspoListResponse<DocumentFolder>>(
"DocumentFolder?orderBy=name&order=asc&maxSize=200",
cancellationToken).ConfigureAwait(false);
_logger.Information(
"ListDocumentFoldersAsync → {Count} folders in tenant",
result?.List?.Count ?? 0);
return result ?? new EspoListResponse<DocumentFolder>();
}
catch (Exception ex)
{
_logger.Warning(ex, "ListDocumentFoldersAsync failed; returning empty list");
return new EspoListResponse<DocumentFolder>();
}
}
public async Task<EspoListResponse<CaseEntity>> ListCasesForContactAsync(string contactId, int maxSize = 5, CancellationToken cancellationToken = default)
{
if (string.IsNullOrWhiteSpace(contactId)) throw new ArgumentException("contactId required", nameof(contactId));
@@ -343,14 +657,20 @@ namespace MarcusLaw.OutlookAddin.Core.Services
if (response.IsSuccessStatusCode) return;
var body = await ReadBodyAsync(response).ConfigureAwait(false);
if (response.StatusCode == HttpStatusCode.Unauthorized || response.StatusCode == HttpStatusCode.Forbidden)
// Only 401 is unambiguously an authentication problem. 403 in
// EspoCRM is "you are who you say you are, but THIS operation
// isn't allowed" — content type rejected, ACL miss, required
// role missing, etc. Conflating them aborts whole batches.
if (response.StatusCode == HttpStatusCode.Unauthorized)
{
throw new EspoCrmAuthorizationException(
$"EspoCRM rejected credentials ({(int)response.StatusCode} {response.StatusCode}). Re-enter API key.");
}
var reason = response.Headers.TryGetValues("X-Status-Reason", out var v)
? " (reason: " + string.Join(",", v) + ")" : string.Empty;
throw new EspoCrmHttpException(response.StatusCode, body,
$"EspoCRM returned {(int)response.StatusCode} {response.StatusCode}: {Truncate(body, 500)}");
$"EspoCRM returned {(int)response.StatusCode} {response.StatusCode}{reason}: {Truncate(body, 500)}");
}
private static async Task<string> ReadBodyAsync(HttpResponseMessage response)
@@ -0,0 +1,79 @@
using System.Collections.Generic;
using System.Threading;
using System.Threading.Tasks;
using MarcusLaw.OutlookAddin.Core.Models;
namespace MarcusLaw.OutlookAddin.Core.Services
{
public interface IAttachmentSaveService
{
/// <summary>
/// Uploads each attachment as an EspoCRM Attachment, then asks
/// Marcus-Law's NetworkStorage integration to place the file under
/// <paramref name="targetFolderPath"/> on the shared storage. No
/// Document entity is created — these are raw files dropped into
/// the case's filesystem folder.
/// </summary>
/// <param name="attachments">files to save</param>
/// <param name="targetFolderPath">
/// Full relative folder path on storage, e.g.
/// <c>"30-מרדכי שמביקו/אסמכתאות"</c>. The case folder + optional
/// subfolder. Filename is appended internally.
/// </param>
Task<AttachmentSaveSummary> SaveAsync(
IReadOnlyList<EspoAttachment> attachments,
string targetFolderPath,
CancellationToken cancellationToken = default);
}
public sealed class AttachmentSaveSummary
{
public List<AttachmentSaveItemResult> Items { get; set; } = new List<AttachmentSaveItemResult>();
public bool AuthRequired { get; set; }
public int SavedCount
{
get
{
var n = 0;
foreach (var it in Items)
{
if (it.Outcome == AttachmentSaveOutcome.Saved) n++;
}
return n;
}
}
public int FailedCount
{
get
{
var n = 0;
foreach (var it in Items)
{
if (it.Outcome == AttachmentSaveOutcome.Failed) n++;
}
return n;
}
}
}
public sealed class AttachmentSaveItemResult
{
public string FileName { get; set; } = string.Empty;
public AttachmentSaveOutcome Outcome { get; set; }
public string? AttachmentId { get; set; }
public string? ErrorMessage { get; set; }
}
public enum AttachmentSaveOutcome
{
Saved,
Failed,
AuthRequired
}
}
@@ -15,5 +15,16 @@ namespace MarcusLaw.OutlookAddin.Core.Services
Task<ContactEntity> CreateContactAsync(string name, string? emailAddress = null, CancellationToken cancellationToken = default);
Task<EspoListResponse<CaseEntity>> ListCasesForContactAsync(string contactId, int maxSize = 5, CancellationToken cancellationToken = default);
Task<UserInfo> TestConnectionAsync(CancellationToken cancellationToken = default);
Task<AttachmentEntity> UploadAttachmentAsync(string fileName, string contentType, string base64Content, CancellationToken cancellationToken = default);
Task<DocumentEntity> CreateDocumentAsync(string name, string attachmentFileId, string? parentType, string? parentId, string? folderId, CancellationToken cancellationToken = default);
Task<EspoListResponse<DocumentFolder>> ListDocumentFoldersAsync(CancellationToken cancellationToken = default);
Task<System.Collections.Generic.List<DocumentFolder>> ListFoldersUsedInCaseAsync(string caseId, CancellationToken cancellationToken = default);
// Marcus-Law NetworkStorageIntegration endpoints (filesystem-based
// folder structure under the case folder).
Task EnsureCaseSubfoldersAsync(string caseId, CancellationToken cancellationToken = default);
Task<System.Collections.Generic.List<NetworkStorageItem>> ListNetworkStorageFolderAsync(string path, CancellationToken cancellationToken = default);
Task UploadAttachmentToNetworkStorageAsync(string attachmentId, string targetPath, CancellationToken cancellationToken = default);
}
}
@@ -0,0 +1,214 @@
<Window x:Class="MarcusLaw.OutlookAddin.UI.Dialogs.SaveAttachmentsDialog"
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
Title="שמור קבצים מצורפים ל-Klear"
Height="560" Width="620"
MinHeight="420" MinWidth="500"
FlowDirection="RightToLeft"
WindowStartupLocation="CenterOwner"
ShowInTaskbar="False"
ResizeMode="CanResize"
Background="#F8FAFC"
FontFamily="Segoe UI, David, Frank Ruehl, Arial">
<Window.Resources>
<SolidColorBrush x:Key="Primary" Color="#2563EB" />
<SolidColorBrush x:Key="PrimaryHover" Color="#1D4ED8" />
<SolidColorBrush x:Key="Border" Color="#E2E8F0" />
<SolidColorBrush x:Key="Muted" Color="#64748B" />
<SolidColorBrush x:Key="CardBg" Color="White" />
<SolidColorBrush x:Key="HoverBg" Color="#F1F5F9" />
<SolidColorBrush x:Key="SelectedBg" Color="#DBEAFE" />
<Style x:Key="Card" TargetType="Border">
<Setter Property="Background" Value="{StaticResource CardBg}" />
<Setter Property="BorderBrush" Value="{StaticResource Border}" />
<Setter Property="BorderThickness" Value="1" />
<Setter Property="CornerRadius" Value="6" />
</Style>
<Style x:Key="PrimaryButton" TargetType="Button">
<Setter Property="Background" Value="{StaticResource Primary}" />
<Setter Property="Foreground" Value="White" />
<Setter Property="BorderThickness" Value="0" />
<Setter Property="Padding" Value="22,8" />
<Setter Property="FontWeight" Value="SemiBold" />
<Setter Property="MinWidth" Value="110" />
<Setter Property="Cursor" Value="Hand" />
<Setter Property="Template">
<Setter.Value>
<ControlTemplate TargetType="Button">
<Border x:Name="Bd" Background="{TemplateBinding Background}" CornerRadius="5" Padding="{TemplateBinding Padding}">
<ContentPresenter HorizontalAlignment="Center" VerticalAlignment="Center" />
</Border>
<ControlTemplate.Triggers>
<Trigger Property="IsMouseOver" Value="True">
<Setter TargetName="Bd" Property="Background" Value="{StaticResource PrimaryHover}" />
</Trigger>
<Trigger Property="IsEnabled" Value="False">
<Setter TargetName="Bd" Property="Background" Value="#94A3B8" />
</Trigger>
</ControlTemplate.Triggers>
</ControlTemplate>
</Setter.Value>
</Setter>
</Style>
<Style x:Key="SecondaryButton" TargetType="Button">
<Setter Property="Background" Value="White" />
<Setter Property="Foreground" Value="#0F172A" />
<Setter Property="BorderBrush" Value="{StaticResource Border}" />
<Setter Property="BorderThickness" Value="1" />
<Setter Property="Padding" Value="20,8" />
<Setter Property="MinWidth" Value="110" />
<Setter Property="Cursor" Value="Hand" />
<Setter Property="Template">
<Setter.Value>
<ControlTemplate TargetType="Button">
<Border x:Name="Bd" Background="{TemplateBinding Background}"
BorderBrush="{TemplateBinding BorderBrush}"
BorderThickness="{TemplateBinding BorderThickness}"
CornerRadius="5" Padding="{TemplateBinding Padding}">
<ContentPresenter HorizontalAlignment="Center" VerticalAlignment="Center" />
</Border>
<ControlTemplate.Triggers>
<Trigger Property="IsMouseOver" Value="True">
<Setter TargetName="Bd" Property="Background" Value="{StaticResource HoverBg}" />
</Trigger>
</ControlTemplate.Triggers>
</ControlTemplate>
</Setter.Value>
</Setter>
</Style>
<Style x:Key="CaseItem" TargetType="ListBoxItem">
<Setter Property="Padding" Value="0" />
<Setter Property="Margin" Value="0" />
<Setter Property="Background" Value="Transparent" />
<Setter Property="Template">
<Setter.Value>
<ControlTemplate TargetType="ListBoxItem">
<Border x:Name="Bd" Background="{TemplateBinding Background}" CornerRadius="4"
Margin="2,1" Padding="8,6">
<ContentPresenter />
</Border>
<ControlTemplate.Triggers>
<Trigger Property="IsMouseOver" Value="True">
<Setter TargetName="Bd" Property="Background" Value="{StaticResource HoverBg}" />
</Trigger>
<Trigger Property="IsSelected" Value="True">
<Setter TargetName="Bd" Property="Background" Value="{StaticResource SelectedBg}" />
</Trigger>
</ControlTemplate.Triggers>
</ControlTemplate>
</Setter.Value>
</Setter>
</Style>
</Window.Resources>
<Grid Margin="16">
<Grid.RowDefinitions>
<RowDefinition Height="Auto" />
<RowDefinition Height="*" />
<RowDefinition Height="Auto" />
<RowDefinition Height="Auto" />
<RowDefinition Height="Auto" />
<RowDefinition Height="Auto" />
</Grid.RowDefinitions>
<!-- Search -->
<Border Grid.Row="0" Style="{StaticResource Card}" Padding="10,8" Margin="0,0,0,8">
<DockPanel LastChildFill="True">
<TextBlock DockPanel.Dock="Left" Text="🔍" VerticalAlignment="Center" FontSize="16" Margin="0,0,8,0" />
<TextBox x:Name="SearchBox"
Text="{Binding SearchText, UpdateSourceTrigger=PropertyChanged}"
BorderThickness="0"
Background="Transparent"
FontSize="14"
VerticalAlignment="Center" />
</DockPanel>
</Border>
<!-- Cases -->
<Border Grid.Row="1" Style="{StaticResource Card}">
<ListBox ItemsSource="{Binding Cases}"
SelectedItem="{Binding SelectedCase}"
BorderThickness="0"
Background="Transparent"
ItemContainerStyle="{StaticResource CaseItem}"
Padding="4">
<ListBox.ItemTemplate>
<DataTemplate>
<StackPanel>
<TextBlock FontSize="13">
<Run Text="[" /><Run Text="{Binding Number, Mode=OneWay}" /><Run Text="] " />
<Run Text="{Binding Name, Mode=OneWay}" FontWeight="SemiBold" />
</TextBlock>
</StackPanel>
</DataTemplate>
</ListBox.ItemTemplate>
</ListBox>
</Border>
<!-- Folder -->
<DockPanel Grid.Row="2" Margin="0,10,0,0" LastChildFill="True">
<TextBlock DockPanel.Dock="Left" Text="תיקייה:" VerticalAlignment="Center"
Margin="0,0,8,0" Foreground="{StaticResource Muted}" FontSize="12" />
<ComboBox ItemsSource="{Binding Subfolders}"
SelectedItem="{Binding SelectedSubfolder}"
Padding="6,4" />
</DockPanel>
<!-- Attachments header -->
<TextBlock Grid.Row="3" Margin="0,12,0,4" Foreground="{StaticResource Muted}" FontSize="12">
<Run Text="קבצים מצורפים (" /><Run Text="{Binding Attachments.Count, Mode=OneWay}" /><Run Text=")" />
</TextBlock>
<!-- Attachments list -->
<Border Grid.Row="4" Style="{StaticResource Card}" MaxHeight="160">
<ScrollViewer VerticalScrollBarVisibility="Auto">
<ItemsControl ItemsSource="{Binding Attachments}" Margin="6">
<ItemsControl.ItemTemplate>
<DataTemplate>
<DockPanel Margin="0,3" LastChildFill="True">
<CheckBox DockPanel.Dock="Right" IsChecked="{Binding IsSelected, Mode=TwoWay}"
VerticalAlignment="Center" />
<TextBlock Text="{Binding SizeDisplay}"
DockPanel.Dock="Left"
Foreground="{StaticResource Muted}"
FontSize="11"
VerticalAlignment="Center"
Margin="8,0,0,0" />
<TextBlock Text="{Binding FileName}"
VerticalAlignment="Center"
TextTrimming="CharacterEllipsis"
Margin="8,0,0,0" />
</DockPanel>
</DataTemplate>
</ItemsControl.ItemTemplate>
</ItemsControl>
</ScrollViewer>
</Border>
<!-- Action row -->
<DockPanel Grid.Row="5" Margin="0,12,0,0" LastChildFill="True">
<TextBlock DockPanel.Dock="Right"
Text="{Binding StatusMessage}"
VerticalAlignment="Center"
Margin="0,0,8,0"
Foreground="{StaticResource Muted}"
FontSize="12"
TextTrimming="CharacterEllipsis" />
<StackPanel Orientation="Horizontal" HorizontalAlignment="Left">
<Button Command="{Binding SubmitCommand}"
IsDefault="True"
Content="שמור"
Style="{StaticResource PrimaryButton}"
Margin="0,0,8,0" />
<Button Command="{Binding CancelCommand}"
IsCancel="True"
Content="ביטול"
Style="{StaticResource SecondaryButton}" />
</StackPanel>
</DockPanel>
</Grid>
</Window>
@@ -0,0 +1,36 @@
using System;
using System.Windows;
using MarcusLaw.OutlookAddin.UI.ViewModels;
namespace MarcusLaw.OutlookAddin.UI.Dialogs
{
public partial class SaveAttachmentsDialog : Window
{
private SaveAttachmentsViewModel? _viewModel;
public SaveAttachmentsDialog()
{
InitializeComponent();
Loaded += (_, __) => SearchBox.Focus();
}
public SaveAttachmentsDialog(SaveAttachmentsViewModel viewModel) : this()
{
AttachViewModel(viewModel);
}
public void AttachViewModel(SaveAttachmentsViewModel viewModel)
{
if (_viewModel != null) _viewModel.RequestClose -= OnRequestClose;
_viewModel = viewModel ?? throw new ArgumentNullException(nameof(viewModel));
DataContext = _viewModel;
_viewModel.RequestClose += OnRequestClose;
}
private void OnRequestClose(object? sender, EventArgs e)
{
DialogResult = _viewModel?.DialogResult;
Close();
}
}
}
@@ -100,7 +100,18 @@
<StackPanel Margin="16">
<TextBlock Text="Marcus-Law OutlookAddin" FontWeight="Bold" FontSize="16" />
<TextBlock Text="תוסף Klear ל-Microsoft Outlook" Margin="0,4,0,12" />
<TextBlock Text="{Binding VersionLine}" Foreground="Gray" />
<DockPanel LastChildFill="False" Margin="0,0,0,4">
<TextBlock DockPanel.Dock="Left" Text="{Binding VersionLine}" Foreground="Gray" VerticalAlignment="Center" />
<Button DockPanel.Dock="Right"
Command="{Binding CheckForUpdateCommand}"
Content="בדוק עדכונים"
Padding="14,4"
MinWidth="120" />
</DockPanel>
<TextBlock Text="{Binding UpdateStatus}"
Foreground="{Binding UpdateStatusBrush}"
TextWrapping="Wrap"
Margin="0,4,0,0" />
<TextBlock Margin="0,16,0,0" TextWrapping="Wrap"
Text="לוגים: %LOCALAPPDATA%\MarcusLaw\OutlookAddin\logs" />
<TextBlock TextWrapping="Wrap"
@@ -18,6 +18,7 @@
<ItemGroup>
<Reference Include="System.Net.Http" />
<Reference Include="System.Deployment" />
</ItemGroup>
<ItemGroup>
@@ -0,0 +1,41 @@
using CommunityToolkit.Mvvm.ComponentModel;
using MarcusLaw.OutlookAddin.Core.Models;
namespace MarcusLaw.OutlookAddin.UI.ViewModels
{
public sealed partial class AttachmentRowViewModel : ObservableObject
{
public EspoAttachment Data { get; }
[ObservableProperty]
private bool isSelected = true;
public string FileName => Data.Name;
public string SizeDisplay { get; }
public AttachmentRowViewModel(EspoAttachment data)
{
Data = data;
SizeDisplay = ComputeSize(data.ContentBase64);
}
private static string ComputeSize(string base64)
{
if (string.IsNullOrEmpty(base64)) return string.Empty;
// Base64 expands binary 4-for-3, ignoring padding chars.
var padding = 0;
if (base64.Length > 0 && base64[base64.Length - 1] == '=') padding++;
if (base64.Length > 1 && base64[base64.Length - 2] == '=') padding++;
var bytes = (long)((base64.Length * 3) / 4) - padding;
return FormatBytes(bytes);
}
private static string FormatBytes(long bytes)
{
if (bytes < 1024) return bytes + " B";
if (bytes < 1024 * 1024) return (bytes / 1024.0).ToString("F1") + " KB";
return (bytes / (1024.0 * 1024.0)).ToString("F1") + " MB";
}
}
}
@@ -0,0 +1,309 @@
using System;
using System.Collections.Generic;
using System.Collections.ObjectModel;
using System.Threading;
using System.Threading.Tasks;
using CommunityToolkit.Mvvm.ComponentModel;
using CommunityToolkit.Mvvm.Input;
using MarcusLaw.OutlookAddin.Core.Models;
using MarcusLaw.OutlookAddin.Core.Services;
using Serilog;
namespace MarcusLaw.OutlookAddin.UI.ViewModels
{
/// <summary>
/// Picks a Case + optional subfolder (filesystem-style, via Marcus-Law's
/// NetworkStorageIntegration) for saving raw attachment files.
/// </summary>
public sealed partial class SaveAttachmentsViewModel : ObservableObject
{
// Default subfolders the integration creates under each Case folder.
// Mirrors Resources/metadata/app/networkStorage.json on the server.
private static readonly string[] DefaultCaseSubfolders =
{
"מסמכים",
"אסמכתאות",
"התכתבויות",
"כללי"
};
private const string RootSentinel = "(שורש התיק)";
private readonly IEspoCrmClient _client;
private readonly ILogger _logger;
private CancellationTokenSource? _searchCts;
[ObservableProperty]
private string searchText = string.Empty;
[ObservableProperty]
private CaseEntity? selectedCase;
[ObservableProperty]
private string? selectedSubfolder;
[ObservableProperty]
private string? statusMessage;
/// <summary>
/// Resolved server-side case folder path for the currently
/// selected case (e.g. "47-אריאל מונאס"). Populated by
/// <see cref="RefreshSubfoldersForSelectedCaseAsync"/> after the
/// case + primary contact have been fetched. Empty until then.
/// </summary>
public string? ResolvedCaseFolderPath { get; private set; }
public ObservableCollection<CaseEntity> Cases { get; } = new ObservableCollection<CaseEntity>();
public ObservableCollection<string> Subfolders { get; } = new ObservableCollection<string>();
public ObservableCollection<AttachmentRowViewModel> Attachments { get; } = new ObservableCollection<AttachmentRowViewModel>();
public bool? DialogResult { get; private set; }
public IReadOnlyList<EspoAttachment> SelectedAttachments
{
get
{
var list = new List<EspoAttachment>();
foreach (var row in Attachments)
{
if (row.IsSelected) list.Add(row.Data);
}
return list;
}
}
/// <summary>
/// Subfolder string the user picked, or null to save to the case
/// folder root.
/// </summary>
public string? ChosenSubfolderName =>
string.IsNullOrEmpty(SelectedSubfolder) ||
string.Equals(SelectedSubfolder, RootSentinel, StringComparison.Ordinal)
? null
: SelectedSubfolder;
public CaseEntity? PickedCase => SelectedCase;
public event EventHandler? RequestClose;
public SaveAttachmentsViewModel(
IEspoCrmClient client,
ILogger logger,
IEnumerable<EspoAttachment> attachments)
{
_client = client ?? throw new ArgumentNullException(nameof(client));
_logger = logger ?? throw new ArgumentNullException(nameof(logger));
ResetSubfolders();
foreach (var att in attachments)
{
Attachments.Add(new AttachmentRowViewModel(att));
}
}
private void ResetSubfolders()
{
Subfolders.Clear();
Subfolders.Add(RootSentinel);
foreach (var f in DefaultCaseSubfolders) Subfolders.Add(f);
SelectedSubfolder = Subfolders[0];
}
partial void OnSearchTextChanged(string value)
{
_searchCts?.Cancel();
_searchCts = new CancellationTokenSource();
_ = SearchAsync(value, _searchCts.Token);
}
partial void OnSelectedCaseChanged(CaseEntity? value)
{
SubmitCommand.NotifyCanExecuteChanged();
_ = RefreshSubfoldersForSelectedCaseAsync();
}
/// <summary>
/// Refreshes the subfolder dropdown to merge static defaults with
/// the actual folders that already exist on the network share for
/// the chosen case. Also resolves <see cref="ResolvedCaseFolderPath"/>
/// using the same logic as the server (primary contact's name, not
/// the case's lawsuit title).
/// </summary>
public async Task RefreshSubfoldersForSelectedCaseAsync()
{
ResetSubfolders();
ResolvedCaseFolderPath = null;
var c = SelectedCase;
if (c == null || string.IsNullOrEmpty(c.Id)) return;
try { await _client.EnsureCaseSubfoldersAsync(c.Id).ConfigureAwait(true); }
catch (Exception ex) { _logger.Warning(ex, "EnsureCaseSubfolders failed; subfolders may be missing on disk"); }
string? primaryContactName = null;
try
{
var detail = await _client.GetCaseAsync(
c.Id, "id,name,number,contactsIds,networkStorageFolderPath", default).ConfigureAwait(true);
c.Number = detail.Number;
c.Name = detail.Name;
c.NetworkStorageFolderPath = detail.NetworkStorageFolderPath;
c.ContactsIds = detail.ContactsIds ?? new List<string>();
if (c.ContactsIds.Count > 0)
{
try
{
var contact = await _client.GetContactAsync(c.ContactsIds[0], "id,name", default).ConfigureAwait(true);
primaryContactName = contact?.Name;
}
catch (Exception ex) { _logger.Warning(ex, "Primary contact fetch failed for case {CaseId}", c.Id); }
}
}
catch (Exception ex) { _logger.Warning(ex, "GetCase for subfolder list failed"); }
var folderPath = ResolveCaseFolderPath(c, primaryContactName);
ResolvedCaseFolderPath = folderPath;
_logger.Information(
"Resolved case folder for {CaseId} (number={Number}, contact={Contact}, stored={Stored}) → {Path}",
c.Id, c.Number ?? "(none)", primaryContactName ?? "(none)", c.NetworkStorageFolderPath ?? "(none)", folderPath);
if (string.IsNullOrEmpty(folderPath)) return;
try
{
var items = await _client.ListNetworkStorageFolderAsync(folderPath).ConfigureAwait(true);
foreach (var item in items)
{
if (!item.IsFolder) continue;
if (Subfolders.Contains(item.Name)) continue;
if (string.Equals(item.Name, RootSentinel, StringComparison.Ordinal)) continue;
Subfolders.Add(item.Name);
}
}
catch (Exception ex)
{
_logger.Warning(ex, "Listing subfolders for case {CaseId} failed", c.Id);
}
}
/// <summary>
/// Mirrors NetworkDocumentService::buildEntityFolderName for Case
/// on the server side. Fallback order:
/// 1) Case.networkStorageFolderPath (if the integration's hook
/// has set it — most authoritative)
/// 2) "&lt;number&gt;-&lt;primary contact name&gt;" ← server's recipe
/// 3) "&lt;number&gt;-&lt;case lawsuit name&gt;"
/// 4) contact / case name on its own
/// </summary>
public static string ResolveCaseFolderPath(CaseEntity c, string? primaryContactName = null)
{
if (c == null) return string.Empty;
if (!string.IsNullOrWhiteSpace(c.NetworkStorageFolderPath))
{
return c.NetworkStorageFolderPath!.TrimEnd('/');
}
var nameForFolder = !string.IsNullOrWhiteSpace(primaryContactName)
? primaryContactName!
: (c.Name ?? string.Empty);
var raw = !string.IsNullOrWhiteSpace(c.Number)
? $"{c.Number}-{nameForFolder}"
: nameForFolder;
return SanitizeFolderSegment(raw);
}
/// <summary>
/// Mirrors LocalFilesystemClient::sanitizeFileName on the server side
/// so client-computed paths match what the integration writes.
/// </summary>
public static string SanitizeFolderSegment(string name)
{
if (string.IsNullOrWhiteSpace(name)) return string.Empty;
foreach (var c in new[] { '׳', '״', '\'', '"', '', '', '“', '”' })
{
name = name.Replace(c.ToString(), string.Empty);
}
foreach (var c in new[] { '/', '\\', ':', '*', '?', '<', '>', '|' })
{
name = name.Replace(c, '-');
}
while (name.Contains("--")) name = name.Replace("--", "-");
while (name.Contains(" ")) name = name.Replace(" ", " ");
name = name.Replace("-.", ".");
return name.Trim(' ', '-');
}
private async Task SearchAsync(string query, CancellationToken ct)
{
try
{
await Task.Delay(250, ct).ConfigureAwait(true);
var trimmed = (query ?? string.Empty).Trim();
if (trimmed.Length < 2)
{
Cases.Clear();
StatusMessage = null;
return;
}
var search = await _client.GlobalSearchAsync(trimmed, ct).ConfigureAwait(true);
ct.ThrowIfCancellationRequested();
Cases.Clear();
int kept = 0;
foreach (var hit in search.List)
{
if (!string.Equals(hit.EntityType, "Case", StringComparison.OrdinalIgnoreCase)) continue;
Cases.Add(new CaseEntity
{
Id = hit.Id,
Name = hit.Name
});
kept++;
}
StatusMessage = kept == 0
? "אין תוצאות מסוג תיק (Case)"
: $"נמצאו {kept} תיקים";
}
catch (OperationCanceledException) { /* superseded */ }
catch (EspoCrmAuthorizationException)
{
StatusMessage = "מפתח ה-API נדחה — יש לעדכן בהגדרות";
}
catch (Exception ex)
{
_logger.Warning(ex, "SaveAttachments search failed");
StatusMessage = "שגיאת חיפוש: " + ex.Message;
}
}
[RelayCommand(CanExecute = nameof(CanSubmit))]
private void Submit()
{
DialogResult = true;
RequestClose?.Invoke(this, EventArgs.Empty);
}
private bool CanSubmit()
{
if (SelectedCase == null || string.IsNullOrWhiteSpace(SelectedCase.Id)) return false;
foreach (var row in Attachments)
{
if (row.IsSelected) return true;
}
return false;
}
[RelayCommand]
private void Cancel()
{
DialogResult = false;
RequestClose?.Invoke(this, EventArgs.Empty);
}
}
}
@@ -40,6 +40,15 @@ namespace MarcusLaw.OutlookAddin.UI.ViewModels
[ObservableProperty]
private Brush statusBrush = NeutralBrush;
[ObservableProperty]
private string? updateStatus;
[ObservableProperty]
private Brush updateStatusBrush = NeutralBrush;
[ObservableProperty]
private bool isCheckingForUpdate;
public string InitialApiKey { get; }
public string VersionLine { get; }
@@ -70,8 +79,32 @@ namespace MarcusLaw.OutlookAddin.UI.ViewModels
Username = creds?.Username ?? string.Empty;
InitialApiKey = creds?.ApiKey ?? string.Empty;
var version = typeof(SettingsViewModel).Assembly.GetName().Version?.ToString() ?? "1.0.0";
VersionLine = $"גרסה {version}";
VersionLine = $"גרסה {ResolveDisplayVersion()}";
}
/// <summary>
/// Picks the most accurate version to surface in the About tab:
/// the ClickOnce activation version when the add-in is installed
/// over the wire (auto-updated to the real deployment version),
/// else the assembly's AssemblyVersion (which is set per-source
/// and may lag behind the deployed ClickOnce manifest).
/// </summary>
private static string ResolveDisplayVersion()
{
try
{
if (System.Deployment.Application.ApplicationDeployment.IsNetworkDeployed)
{
return System.Deployment.Application.ApplicationDeployment
.CurrentDeployment.CurrentVersion.ToString();
}
}
catch
{
// Not running under ClickOnce (dev / F5), or System.Deployment
// is not available — fall through to the AssemblyVersion.
}
return typeof(SettingsViewModel).Assembly.GetName().Version?.ToString() ?? "1.0.0";
}
/// <summary>
@@ -105,6 +138,66 @@ namespace MarcusLaw.OutlookAddin.UI.ViewModels
private static string WatchedKey(string storeId, string path) => storeId + "|" + path;
[RelayCommand(CanExecute = nameof(CanCheckForUpdate))]
private async Task CheckForUpdateAsync()
{
IsCheckingForUpdate = true;
UpdateStatusBrush = NeutralBrush;
UpdateStatus = "בודק עדכונים…";
try
{
if (!System.Deployment.Application.ApplicationDeployment.IsNetworkDeployed)
{
UpdateStatusBrush = ErrorBrush;
UpdateStatus = "התוסף לא מותקן דרך ClickOnce — אין כאן עדכון אוטומטי.";
return;
}
var deployment = System.Deployment.Application.ApplicationDeployment.CurrentDeployment;
var info = await Task.Run(() => deployment.CheckForDetailedUpdate(false)).ConfigureAwait(true);
if (!info.UpdateAvailable)
{
UpdateStatusBrush = SuccessBrush;
UpdateStatus = "אתה על הגרסה האחרונה (" + deployment.CurrentVersion + ").";
return;
}
UpdateStatus = $"זמינה גרסה {info.AvailableVersion} — מוריד…";
var result = await Task.Run(() => deployment.Update()).ConfigureAwait(true);
UpdateStatusBrush = SuccessBrush;
UpdateStatus = $"הותקנה גרסה {info.AvailableVersion}. סגור ופתח את Outlook כדי לטעון אותה.";
}
catch (System.Deployment.Application.DeploymentDownloadException ex)
{
_logger.Warning(ex, "CheckForUpdate: download failed");
UpdateStatusBrush = ErrorBrush;
UpdateStatus = "הורדת העדכון נכשלה: " + ex.Message;
}
catch (System.Deployment.Application.InvalidDeploymentException ex)
{
_logger.Warning(ex, "CheckForUpdate: invalid deployment manifest");
UpdateStatusBrush = ErrorBrush;
UpdateStatus = "ה-deployment manifest על השרת לא תקין: " + ex.Message;
}
catch (Exception ex)
{
_logger.Warning(ex, "CheckForUpdate failed");
UpdateStatusBrush = ErrorBrush;
UpdateStatus = "שגיאה בבדיקת עדכונים: " + ex.Message;
}
finally
{
IsCheckingForUpdate = false;
}
}
private bool CanCheckForUpdate() => !IsCheckingForUpdate;
partial void OnIsCheckingForUpdateChanged(bool value)
{
CheckForUpdateCommand.NotifyCanExecuteChanged();
}
[RelayCommand]
private async Task TestConnectionAsync()
{
Binary file not shown.

After

Width:  |  Height:  |  Size: 647 B

+4 -1
View File
@@ -36,7 +36,7 @@
<PublishUrl>C:\Users\Chaim\source\repos\OutlookAddin\Publish\</PublishUrl>
<InstallUrl>\\192.168.10.97\Projects\LegalCRM\Add-in\</InstallUrl>
<TargetCulture>en</TargetCulture>
<ApplicationVersion>1.0.0.4</ApplicationVersion>
<ApplicationVersion>1.0.0.5</ApplicationVersion>
<AutoIncrementApplicationRevision>true</AutoIncrementApplicationRevision>
<UpdateEnabled>true</UpdateEnabled>
<UpdateInterval>7</UpdateInterval>
@@ -270,6 +270,9 @@
<EmbeddedResource Include="Images\klear-compose.png">
<LogicalName>OutlookAddin.Images.klear-compose.png</LogicalName>
</EmbeddedResource>
<EmbeddedResource Include="Images\klear-attach.png">
<LogicalName>OutlookAddin.Images.klear-attach.png</LogicalName>
</EmbeddedResource>
<Compile Include="Services\AddInHost.cs">
<SubType>Code</SubType>
</Compile>
+58 -2
View File
@@ -19,7 +19,15 @@ namespace OutlookAddin.Ribbon
{
private const string ExplorerResource = "OutlookAddin.Ribbon.ExplorerRibbon.xml";
private const string InspectorResource = "OutlookAddin.Ribbon.InspectorRibbon.xml";
private const string FileButtonId = "FileToEspoCrm";
// Every button whose `getEnabled` depends on the current Explorer
// selection must be re-evaluated on every SelectionChange — Office
// caches the initial result otherwise and the button stays stuck.
private static readonly string[] SelectionDependentButtons =
{
"FileToEspoCrm",
"SaveAttachments"
};
private IRibbonUI? _explorerRibbon;
private IRibbonUI? _inspectorRibbon;
@@ -45,7 +53,7 @@ namespace OutlookAddin.Ribbon
var explorer = Globals.ThisAddIn.Application.ActiveExplorer();
if (explorer != null)
{
explorer.SelectionChange += () => _explorerRibbon?.InvalidateControl(FileButtonId);
explorer.SelectionChange += InvalidateSelectionDependentButtons;
}
}
catch
@@ -54,6 +62,16 @@ namespace OutlookAddin.Ribbon
}
}
private void InvalidateSelectionDependentButtons()
{
var ribbon = _explorerRibbon;
if (ribbon == null) return;
foreach (var id in SelectionDependentButtons)
{
try { ribbon.InvalidateControl(id); } catch { /* ignore */ }
}
}
public void OnInspectorRibbonLoad(IRibbonUI ribbon)
{
_inspectorRibbon = ribbon;
@@ -92,6 +110,43 @@ namespace OutlookAddin.Ribbon
Globals.ThisAddIn.AddInHost.ShowSidebar();
}
public bool OnGetSaveAttachmentsEnabled(IRibbonControl control)
{
// Enabled only when EXACTLY one MailItem is selected AND it has
// at least one attachment. Doing multi-mail save would conflict
// with the per-file checkbox UX in the dialog.
try
{
var selection = Globals.ThisAddIn.Application.ActiveExplorer()?.Selection;
if (selection == null || selection.Count != 1) return false;
if (selection[1] is not Outlook.MailItem mail) return false;
var attachments = mail.Attachments;
if (attachments == null) return false;
return attachments.Count > 0;
}
catch
{
return false;
}
}
public void OnSaveAttachments(IRibbonControl control)
{
try
{
var selection = Globals.ThisAddIn.Application.ActiveExplorer()?.Selection;
if (selection == null || selection.Count != 1) return;
if (selection[1] is Outlook.MailItem mail)
{
_ = Globals.ThisAddIn.AddInHost.LaunchSaveAttachmentsAsync(mail);
}
}
catch (Exception ex)
{
Globals.ThisAddIn.AddInHost.Logger.Warning(ex, "OnSaveAttachments failed");
}
}
public bool OnGetComposeFromCaseVisible(IRibbonControl control)
{
// Show only on outgoing (compose) mail inspectors.
@@ -150,6 +205,7 @@ namespace OutlookAddin.Ribbon
switch (control.Id)
{
case "FileToEspoCrm": fileName = "klear-file.png"; break;
case "SaveAttachments": fileName = "klear-attach.png"; break;
case "ShowSidebar": fileName = "klear-sidebar.png"; break;
case "OpenEspoCrmSettings": fileName = "klear-settings.png"; break;
case "ComposeFromCase": fileName = "klear-compose.png"; break;
@@ -12,6 +12,14 @@
getImage="OnGetImage"
onAction="OnFileToEspoCrm"
getEnabled="OnGetFileToEspoCrmEnabled" />
<button id="SaveAttachments"
label="שמור קבצים"
screentip="שמור את הקבצים המצורפים בלבד"
supertip="מעלה את הקבצים המצורפים של המייל הנבחר ל-Klear כ-Documents מקושרים לתיק שתבחר, בלי לתייק את המייל עצמו."
size="large"
getImage="OnGetImage"
onAction="OnSaveAttachments"
getEnabled="OnGetSaveAttachmentsEnabled" />
<button id="ShowSidebar"
label="פרטי תיק"
screentip="הצג את סרגל פרטי התיק"
+133
View File
@@ -38,6 +38,7 @@ namespace OutlookAddin.Services
public IEspoCrmClient? CrmClient { get; private set; }
public IFilingService? FilingService { get; private set; }
public IMatchingService? MatchingService { get; private set; }
public IAttachmentSaveService? AttachmentSaveService { get; private set; }
public ComposeService? ComposeService { get; private set; }
private readonly Outlook.Application _outlookApp;
@@ -353,6 +354,7 @@ namespace OutlookAddin.Services
FilingService = new FilingService(CrmClient, RetryQueue, Logger);
MatchingService = new MatchingService(CrmClient, _matchCache, Logger);
ComposeService = new ComposeService(CrmClient, Logger);
AttachmentSaveService = new AttachmentSaveService(CrmClient, Logger);
_folderResolver ??= new FolderResolver(_outlookApp, Logger);
_folderWatcher = new FolderWatcher(
_outlookApp,
@@ -387,6 +389,7 @@ namespace OutlookAddin.Services
FilingService = null;
MatchingService = null;
ComposeService = null;
AttachmentSaveService = null;
}
/// <summary>
@@ -428,6 +431,136 @@ namespace OutlookAddin.Services
}
}
/// <summary>
/// Save-attachments-only flow. The user clicks the ribbon's "שמור
/// קבצים" button while standing on a mail with one or more
/// attachments. We extract the attachments (no Email entity
/// created), let the user pick a Case + optional DocumentFolder,
/// then upload each attachment + create a Document linked to the
/// case.
/// </summary>
public async Task LaunchSaveAttachmentsAsync(Outlook.MailItem mail)
{
if (mail == null) return;
if (!IsConfigured)
{
var result = MessageBox.Show(
"התוסף עדיין לא מוגדר. לפתוח את חלון ההגדרות עכשיו?",
"Marcus-Law OutlookAddin",
MessageBoxButton.YesNo,
MessageBoxImage.Information);
if (result == MessageBoxResult.Yes) LaunchSettings();
if (!IsConfigured) return;
}
// Extract on the STA — MailItemExtractor handles all COM access
// and gives us a self-contained envelope.
MailEnvelope envelope;
try
{
envelope = MailItemExtractor.Extract(mail);
}
catch (Exception ex)
{
Logger.Error(ex, "LaunchSaveAttachmentsAsync: extract failed");
MessageBox.Show(
"קריאת הקבצים המצורפים נכשלה: " + ex.Message,
"Marcus-Law OutlookAddin",
MessageBoxButton.OK,
MessageBoxImage.Error);
return;
}
if (envelope.Attachments.Count == 0)
{
MessageBox.Show(
"אין במייל הזה קבצים מצורפים לשמירה.",
"Marcus-Law OutlookAddin",
MessageBoxButton.OK,
MessageBoxImage.Information);
return;
}
var vm = new SaveAttachmentsViewModel(CrmClient!, Logger, envelope.Attachments);
// Subfolders are populated lazily once the user picks a case;
// the default static set is already pre-loaded.
var dialog = new SaveAttachmentsDialog(vm);
AttachOwnerToOutlook(dialog);
var ok = dialog.ShowDialog();
if (ok != true) return;
var picked = vm.PickedCase;
var selected = vm.SelectedAttachments;
if (picked == null || string.IsNullOrEmpty(picked.Id) || selected.Count == 0) return;
// Prefer the path the VM resolved when the user picked the case
// (it already fetched the primary contact and applied the
// server's naming convention). Fall back to the no-contact
// resolve only if that step somehow didn't run.
var caseFolder = !string.IsNullOrWhiteSpace(vm.ResolvedCaseFolderPath)
? vm.ResolvedCaseFolderPath!
: SaveAttachmentsViewModel.ResolveCaseFolderPath(picked);
if (string.IsNullOrEmpty(caseFolder))
{
MessageBox.Show(
"לא ניתן לחשב את נתיב התיקייה של התיק. ייתכן שהתיק עוד לא הוגדר ב-Klear.",
"Marcus-Law OutlookAddin",
MessageBoxButton.OK,
MessageBoxImage.Warning);
return;
}
var subfolder = vm.ChosenSubfolderName;
var targetFolderPath = string.IsNullOrEmpty(subfolder)
? caseFolder
: caseFolder + "/" + subfolder;
try
{
Logger.Information(
"Saving {Count} attachment(s) to Case/{Id} ({Name}) → {Path}",
selected.Count, picked.Id, picked.Name, targetFolderPath);
// Safety net: ensure the case folder + defaults exist on
// disk before the per-file uploads (the dialog may have
// been submitted before the prior ensure call finished).
try { await CrmClient!.EnsureCaseSubfoldersAsync(picked.Id).ConfigureAwait(true); }
catch (Exception ex) { Logger.Warning(ex, "Pre-upload ensure failed; continuing anyway"); }
var summary = await AttachmentSaveService!.SaveAsync(selected, targetFolderPath).ConfigureAwait(true);
ShowAttachmentSummary(summary, picked.Name ?? picked.Id, targetFolderPath);
}
catch (Exception ex)
{
Logger.Error(ex, "LaunchSaveAttachmentsAsync failed");
MessageBox.Show(
"שמירת הקבצים נכשלה: " + ex.Message,
"Marcus-Law OutlookAddin",
MessageBoxButton.OK,
MessageBoxImage.Error);
}
}
private static void ShowAttachmentSummary(AttachmentSaveSummary summary, string caseLabel, string targetPath)
{
string message;
MessageBoxImage icon;
if (summary.AuthRequired)
{
message = "מפתח ה-API נדחה. יש לעדכן את ההגדרות ולנסות שוב.";
icon = MessageBoxImage.Warning;
}
else
{
var parts = new List<string>();
if (summary.SavedCount > 0) parts.Add($"נשמרו {summary.SavedCount} קבצים אל \"{caseLabel}\" ({targetPath})");
if (summary.FailedCount > 0) parts.Add($"{summary.FailedCount} נכשלו");
message = parts.Count == 0 ? "לא נשמרו פריטים." : string.Join(" · ", parts);
icon = summary.FailedCount > 0 ? MessageBoxImage.Warning : MessageBoxImage.Information;
}
MessageBox.Show(message, "Marcus-Law OutlookAddin", MessageBoxButton.OK, icon);
}
/// <summary>
/// Entry point for the URL-protocol handler (outlookaddin://compose?caseId=…).
/// Creates a brand new MailItem, populates it with case details, then
+67 -1
View File
@@ -98,9 +98,11 @@ namespace OutlookAddin.Services
{
att.SaveAsFile(tempPath);
var bytes = File.ReadAllBytes(tempPath);
var name = att.FileName ?? "attachment.bin";
env.Attachments.Add(new EspoAttachment
{
Name = att.FileName ?? "attachment.bin",
Name = name,
ContentType = GuessMimeType(name),
ContentBase64 = Convert.ToBase64String(bytes)
});
}
@@ -171,6 +173,70 @@ namespace OutlookAddin.Services
return name;
}
/// <summary>
/// Picks a sane MIME type from the file extension. EspoCRM's default
/// attachment-upload config rejects "application/octet-stream" with
/// "Not allowed file type", so we map common Office / image / archive
/// extensions to canonical MIMEs before posting.
/// </summary>
private static string GuessMimeType(string fileName)
{
if (string.IsNullOrWhiteSpace(fileName)) return "application/octet-stream";
var ext = Path.GetExtension(fileName).ToLowerInvariant();
switch (ext)
{
// Office (legacy + OOXML)
case ".pdf": return "application/pdf";
case ".doc": return "application/msword";
case ".docx": return "application/vnd.openxmlformats-officedocument.wordprocessingml.document";
case ".xls": return "application/vnd.ms-excel";
case ".xlsx": return "application/vnd.openxmlformats-officedocument.spreadsheetml.sheet";
case ".ppt": return "application/vnd.ms-powerpoint";
case ".pptx": return "application/vnd.openxmlformats-officedocument.presentationml.presentation";
case ".rtf": return "application/rtf";
case ".odt": return "application/vnd.oasis.opendocument.text";
case ".ods": return "application/vnd.oasis.opendocument.spreadsheet";
// Text
case ".txt": return "text/plain";
case ".csv": return "text/csv";
case ".log": return "text/plain";
case ".htm":
case ".html": return "text/html";
case ".xml": return "application/xml";
case ".json": return "application/json";
// Images
case ".png": return "image/png";
case ".jpg":
case ".jpeg": return "image/jpeg";
case ".gif": return "image/gif";
case ".bmp": return "image/bmp";
case ".tif":
case ".tiff": return "image/tiff";
case ".webp": return "image/webp";
case ".svg": return "image/svg+xml";
// Archives
case ".zip": return "application/zip";
case ".rar": return "application/x-rar-compressed";
case ".7z": return "application/x-7z-compressed";
case ".gz": return "application/gzip";
case ".tar": return "application/x-tar";
// Email
case ".eml": return "message/rfc822";
case ".msg": return "application/vnd.ms-outlook";
// Audio / video — rare in legal mail but cheap to handle
case ".mp3": return "audio/mpeg";
case ".wav": return "audio/wav";
case ".mp4": return "video/mp4";
default: return "application/octet-stream";
}
}
private static T? SafeGet<T>(Func<T> getter) where T : class
{
try { return getter(); } catch { return null; }