The PDF host (free-justice.openapi.gov.il) requires the same x-client-id
header as the search API, so a normal browser click on the URL fails.
This tool carries the auth header automatically and saves the PDF to a
configurable local directory.
Safety properties:
- SSRF guard: only download from free-justice.openapi.gov.il and
pub-justice.openapi.gov.il.
- Path-traversal guard: filename is reduced to its basename; arbitrary
paths are stripped.
- Content-type guard: rejects 200-OK responses whose body is not a real
PDF (gateway sometimes returns JSON-error 200s).
- Atomic write via .tmp + rename so partial downloads never replace the
cached copy.
- Caches by destination path; re-downloads are no-ops unless overwrite=True.
DECISIVE_APPRAISER_DOWNLOAD_DIR env var configures the output dir
(default: ./downloads/decisive_appraisals). 6 new unit tests cover the
happy path, caching, and all four guards. End-to-end live test confirmed
a 1.4MB real PDF lands on disk with valid `%PDF-1.7` header.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
chaim
4bc054f315