Commit Graph

11 Commits

Author SHA1 Message Date
Nitzan P b78346f3b0 Add statistical refinement and outlier detection system
Implement configurable outlier detection and robust statistical measures to
improve analysis accuracy for real estate data. Addresses issues with data
entry errors, partial deals, and other anomalies that skew statistics.

Key Features:
- IQR-based outlier detection (moderate filtering by default, k=1.5)
- Hard bounds filtering for obvious errors (price_per_sqm, deal_amount)
- Robust volatility using IQR instead of std_dev for investment analysis
- Transparent reporting with both filtered and unfiltered statistics

Implementation:
- Add outlier_detection.py module with IQR/percent/hard bounds methods
- Add OutlierReport model and enhance DealStatistics with filtered fields
- Update calculate_deal_statistics() to support optional outlier filtering
- Update analyze_investment_potential() to use robust volatility
- Add 9 new configuration parameters for customization
- Add comprehensive test suite (24 tests) for outlier detection
- Update CLAUDE.md with usage documentation

Configuration (all via env vars):
- ANALYSIS_OUTLIER_METHOD=iqr (default, or percent/none)
- ANALYSIS_IQR_MULTIPLIER=1.5 (moderate, 3.0=conservative)
- ANALYSIS_PRICE_PER_SQM_MIN/MAX=1000/100000 (bounds in NIS/sqm)
- ANALYSIS_MIN_DEAL_AMOUNT=100000 (catches partial deals)
- ANALYSIS_USE_ROBUST_VOLATILITY=true (IQR-based CV)
- ANALYSIS_USE_ROBUST_TRENDS=true (filter before regression)

Testing:
- All existing tests pass (326 passed)
- 24 new comprehensive outlier detection tests
- Real-world scenario tests (partial deals, data errors)

Backward Compatible:
- Default behavior improves accuracy without breaking changes
- All new fields in models are optional
- Config parameters have sensible defaults

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-19 23:45:41 +02:00
Nitzan Pomerantz fd79ea88bf Fix test_parse_deal_dates_basic temporal assertion
Adjusted sample_deals fixture to ensure 5 deals across 5 distinct months.
Previous dates collapsed into 3 months due to naive 30-day calculations.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-15 00:08:42 +02:00
Nitzan Pomerantz 739d4f8578 Examples and code quality 2025-10-31 00:31:14 +02:00
Nitzan Pomerantz e4aa6487ff Ruff fixes 2025-10-30 22:24:40 +02:00
Nitzan Pomerantz 6632ac1669 Fix failing tests again 2025-10-30 20:54:18 +02:00
Nitzan Pomerantz 67a17b022d Remove irrelevant code as per gemini cr 2025-10-30 20:25:14 +02:00
Nitzan Pomerantz bdfc5e3d3e Apply suggestion from @gemini-code-assist[bot]
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2025-10-30 20:18:09 +02:00
Nitzan Pomerantz 04a1e68604 Phase 5 2025-10-30 18:26:48 +02:00
Nitzan Pomerantz 34af8362b9 CR fixes 2025-10-26 23:26:31 +02:00
Nitzan Pomerantz 0ac9d136cd Implementation of phase 4.1 2025-10-26 10:58:46 +02:00
Nitzan Pomerantz 39266ea6e4 Add comprehensive unit tests for Phase 3 refactoring
Test Coverage Expansion:
- Increased from 34 to 138 tests (+304% improvement)
- All tests passing in 0.50s

New Test Files:
1. tests/govmap/test_validators.py (32 tests)
   - Complete coverage for address validation
   - Coordinate validation with ITM bounds checking
   - Positive integer validation with edge cases
   - Deal type validation

2. tests/govmap/test_utils.py (36 tests)
   - Distance calculation tests (Euclidean, diagonal, symmetric)
   - Address matching tests (case sensitivity, substring matching)
   - Comprehensive Hebrew floor parsing (all 12 Hebrew floor names)
   - Edge cases for floor extraction

3. tests/test_fastmcp_tools.py (36 tests)
   - E2E tests for all 10 MCP tools
   - Tests correct JSON formatting
   - Tests bloat field stripping
   - Tests error handling
   - Tests edge cases (no results, invalid input)

Test Quality:
- All edge cases covered
- Hebrew floor names: קרקע, מרתף, ראשונה-עשירית
- Mock-based for fast execution
- Clear test names and documentation

Updated Documentation:
- Updated TEST_COVERAGE_REPORT.md with new test statistics
- Documented all test categories and coverage

Result: Comprehensive test coverage across all refactored modules

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-10-25 13:55:37 +03:00