CRITICAL FIX: get_deals_by_radius returns polygon metadata, not deals

## Root Cause
After Pydantic migration, get_deals_by_radius() was attempting to validate
API responses as Deal objects. However, this endpoint returns POLYGON METADATA
(with fields: dealscount, polygon_id, settlementNameHeb), NOT individual deals.

All responses failed Pydantic validation (missing dealAmount, dealDate),
resulting in empty lists and 0 deals returned from ALL queries.

## Fixes Applied

### 1. client.py - get_deals_by_radius()
- Return type: `List[Deal]` → `List[Dict[str, Any]]`
- Remove Pydantic validation - return raw metadata dicts
- Update docstring to clarify this returns polygon metadata
- Add note to use find_recent_deals_for_address() for actual deals

### 2. client.py - find_recent_deals_for_address()
- Update to handle polygon metadata dicts (not Deal objects)
- Use dict.get('polygon_id') instead of model attribute access
- Rename variable: `nearby_deals` → `nearby_polygons` for clarity

### 3. fastmcp_server.py - get_deals_by_radius() tool
- Update to handle dict responses (not Deal objects)
- Remove strip_bloat_fields() call (not needed for metadata)
- Update docstring with WARNING about polygon metadata
- Change response keys: "deals" → "polygons", "total_deals" → "total_polygons"

### 4. Tests
- test_govmap_client.py: Update to expect dicts, not Deal objects
- test_fastmcp_tools.py: Update 3 tests to mock dict responses

## Impact
-  find_recent_deals_for_address() NOW WORKS (was returning 0 deals)
-  All 174 tests passing
-  E2E API test confirmed working with real data

## API Behavior Documented
get_deals_by_radius endpoint design:
1. Returns polygon/area metadata (not individual deals)
2. Extract polygon_ids from metadata
3. Call get_street_deals(polygon_id) to get actual deals
4. This workflow is automated in find_recent_deals_for_address()

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Nitzan Pomerantz
2025-10-27 09:38:21 +02:00
parent d8259ae2cf
commit 247ddad8cd
4 changed files with 84 additions and 75 deletions
+31 -33
View File
@@ -130,59 +130,57 @@ class TestGetDealsByRadius:
@patch('nadlan_mcp.fastmcp_server.client')
def test_successful_get_deals(self, mock_client):
"""Test successful deal retrieval."""
# Mock with Deal models
mock_deals = [
Deal(
objectid=123,
deal_amount=2000000,
deal_date="2023-01-01",
asset_area=80.0,
street_name="דיזנגוף"
)
"""Test successful polygon metadata retrieval."""
# Mock with polygon metadata dicts (not Deal objects)
mock_polygons = [
{
"objectid": 123,
"dealscount": "30",
"settlementNameHeb": "תל אביב-יפו",
"streetNameHeb": "דיזנגוף",
"houseNum": 50,
"polygon_id": "123-456"
}
]
mock_client.get_deals_by_radius.return_value = mock_deals
mock_client.get_deals_by_radius.return_value = mock_polygons
result = fastmcp_server.get_deals_by_radius(650000.0, 180000.0, 500)
parsed = json.loads(result)
assert len(parsed["deals"]) == 1
assert parsed["deals"][0]["deal_amount"] == 2000000 # Use snake_case field name
assert parsed["total_deals"] == 1
assert len(parsed["polygons"]) == 1
assert parsed["polygons"][0]["dealscount"] == "30"
assert parsed["total_polygons"] == 1
mock_client.get_deals_by_radius.assert_called_once()
@patch('nadlan_mcp.fastmcp_server.client')
def test_get_deals_no_results(self, mock_client):
"""Test deal retrieval with no results."""
"""Test polygon metadata retrieval with no results."""
mock_client.get_deals_by_radius.return_value = []
result = fastmcp_server.get_deals_by_radius(650000.0, 180000.0, 500)
assert "No deals found" in result or json.loads(result)["total_deals"] == 0
assert "No polygons found" in result
@patch('nadlan_mcp.fastmcp_server.client')
def test_get_deals_strips_bloat_fields(self, mock_client):
"""Test that bloat fields are stripped from response."""
# Mock with Deal models, not dicts
mock_deals = [
Deal(
objectid=123,
deal_amount=2000000,
deal_date="2023-01-01",
shape="MULTIPOLYGON(...huge data...)",
sourceorder=1,
source_polygon_id="abc123"
)
"""Test that polygon metadata is returned as-is."""
# Mock with polygon metadata dicts
mock_polygons = [
{
"objectid": 123,
"dealscount": "10",
"polygon_id": "abc123",
"settlementNameHeb": "Tel Aviv"
}
]
mock_client.get_deals_by_radius.return_value = mock_deals
mock_client.get_deals_by_radius.return_value = mock_polygons
result = fastmcp_server.get_deals_by_radius(650000.0, 180000.0, 500)
parsed = json.loads(result)
# Verify bloat fields are removed
deal = parsed["deals"][0]
assert "shape" not in deal
assert "sourceorder" not in deal
# source_polygon_id is kept when added by our processing
# Polygon metadata is returned as-is (no stripping needed)
polygon = parsed["polygons"][0]
assert polygon["polygon_id"] == "abc123"
assert polygon["dealscount"] == "10"
@patch('nadlan_mcp.fastmcp_server.client')
def test_get_deals_error_handling(self, mock_client):