From 65bef1df6567c9ccc4bd6eca8a8d2da72da7095f Mon Sep 17 00:00:00 2001
From: Yuri Kuznetsov <yurikuzn@users.noreply.github.com>
Date: Thu, 6 Apr 2023 18:57:38 +0300
Subject: [PATCH] fix link-parent not-storable

---
 .../Resources/metadata/fields/linkParent.json |  4 +-
 upgrades/7.4.0-7.4.1/data.json                |  2 +
 upgrades/7.4.0-7.4.1/scripts/AfterUpgrade.php | 68 +++++++++++++++++++
 upgrades/7.4/scripts/AfterUpgrade.php         | 24 +++++++
 4 files changed, 95 insertions(+), 3 deletions(-)
 create mode 100644 upgrades/7.4.0-7.4.1/data.json
 create mode 100644 upgrades/7.4.0-7.4.1/scripts/AfterUpgrade.php

diff --git a/application/Espo/Resources/metadata/fields/linkParent.json b/application/Espo/Resources/metadata/fields/linkParent.json
index e4b1653817..7c54908c5b 100644
--- a/application/Espo/Resources/metadata/fields/linkParent.json
+++ b/application/Espo/Resources/metadata/fields/linkParent.json
@@ -38,9 +38,7 @@
     ],
     "filter": true,
     "notCreatable": true,
-    "fieldDefs": {
-        "notStorable": true
-    },
+
     "valueFactoryClassName": "Espo\\Core\\Field\\LinkParent\\LinkParentFactory",
     "attributeExtractorClassName": "Espo\\Core\\Field\\LinkParent\\LinkParentAttributeExtractor"
 }
diff --git a/upgrades/7.4.0-7.4.1/data.json b/upgrades/7.4.0-7.4.1/data.json
new file mode 100644
index 0000000000..2c63c08510
--- /dev/null
+++ b/upgrades/7.4.0-7.4.1/data.json
@@ -0,0 +1,2 @@
+{
+}
diff --git a/upgrades/7.4.0-7.4.1/scripts/AfterUpgrade.php b/upgrades/7.4.0-7.4.1/scripts/AfterUpgrade.php
new file mode 100644
index 0000000000..2e8e7837ec
--- /dev/null
+++ b/upgrades/7.4.0-7.4.1/scripts/AfterUpgrade.php
@@ -0,0 +1,68 @@
+<?php
+/************************************************************************
+ * This file is part of EspoCRM.
+ *
+ * EspoCRM - Open Source CRM application.
+ * Copyright (C) 2014-2023 Yurii Kuznietsov, Taras Machyshyn, Oleksii Avramenko
+ * Website: https://www.espocrm.com
+ *
+ * EspoCRM is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * EspoCRM is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with EspoCRM. If not, see http://www.gnu.org/licenses/.
+ *
+ * The interactive user interfaces in modified source and object code versions
+ * of this program must display Appropriate Legal Notices, as required under
+ * Section 5 of the GNU General Public License version 3.
+ *
+ * In accordance with Section 7(b) of the GNU General Public License version 3,
+ * these Appropriate Legal Notices must retain the display of the "EspoCRM" word.
+ ************************************************************************/
+
+use Espo\Core\Container;
+use Espo\Core\Utils\Metadata;
+
+class AfterUpgrade
+{
+    public function run(Container $container): void
+    {
+        $this->updateMetadata($container->get('metadata'));
+    }
+
+    private function updateMetadata(Metadata $metadata): void
+    {
+        $this->fixParent($metadata);
+
+        $metadata->save();
+    }
+
+    private function fixParent(Metadata $metadata): void
+    {
+        foreach ($metadata->get(['entityDefs']) as $scope => $defs) {
+            foreach ($metadata->get(['entityDefs', $scope, 'fields']) as $field => $fieldDefs) {
+                $custom = $metadata->getCustom('entityDefs', $scope);
+
+                if (!$custom) {
+                    continue;
+                }
+
+                if (
+                    ($fieldDefs['type'] ?? null) === 'linkParent' &&
+                    ($fieldDefs['notStorable'] ?? false)
+                ) {
+                    if ($custom?->fields?->$field?->notStorable) {
+                        $metadata->delete('entityDefs', $scope, "fields.{$field}.notStorable");
+                    }
+                }
+            }
+        }
+    }
+}
diff --git a/upgrades/7.4/scripts/AfterUpgrade.php b/upgrades/7.4/scripts/AfterUpgrade.php
index cf9e35e45c..64112d12a6 100644
--- a/upgrades/7.4/scripts/AfterUpgrade.php
+++ b/upgrades/7.4/scripts/AfterUpgrade.php
@@ -43,6 +43,30 @@ class AfterUpgrade
             'length' => 24,
         ]);
 
+        $this->fixParent($metadata);
+
         $metadata->save();
     }
+
+    private function fixParent(Metadata $metadata): void
+    {
+        foreach ($metadata->get(['entityDefs']) as $scope => $defs) {
+            foreach ($metadata->get(['entityDefs', $scope, 'fields']) as $field => $fieldDefs) {
+                $custom = $metadata->getCustom('entityDefs', $scope);
+
+                if (!$custom) {
+                    continue;
+                }
+
+                if (
+                    ($fieldDefs['type'] ?? null) === 'linkParent' &&
+                    ($fieldDefs['notStorable'] ?? false)
+                ) {
+                    if ($custom?->fields?->$field?->notStorable) {
+                        $metadata->delete('entityDefs', $scope, "fields.{$field}.notStorable");
+                    }
+                }
+            }
+        }
+    }
 }