fix(2.9.2): add AssistantRule Controller — fixes silent save_rule 404

Without Controllers/AssistantRule.php, EspoCRM responds 404 "Controller
'AssistantRule' does not exist" on every POST/GET /api/v1/AssistantRule,
even though scopes/AssistantRule.json declares entity=true, object=true,
acl=true. The save_rule tool in shira-hermes calls the Record endpoint
directly, gets the 404, falls back to nothing (because the user_id branch
of the fallback rarely matches), and the LLM tells the user "✅ כלל נשמר"
without verification — yet another instance of the hallucination pattern.

A one-line Controller class that extends Espo\Core\Controllers\Record
exposes the standard CRUD verbs and unlocks the storage path that the
rest of the stack already expected. Verified in prod: GET, POST, DELETE
all return 200 after this is in place.

Paired with shira-hermes 06b27e9 which teaches the LLM to actually read
the tool result and never report success on a ❌ response.

Refs Task Master #6

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

files/custom/Espo/Modules/SmartAssistant/Controllers/AssistantRule.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace Espo\Modules\SmartAssistant\Controllers;
+
+/**
+ * Exposes the AssistantRule entity over the standard REST API
+ * (GET/POST/PUT/DELETE /api/v1/AssistantRule).
+ *
+ * Without this controller class EspoCRM responds 404 "Controller does not exist"
+ * even when the entity, object, and acl flags in scopes/AssistantRule.json are
+ * set. Inheriting from Record gives us the full CRUD surface — list/search,
+ * read, create, update, delete — with ACL enforcement.
+ */
+class AssistantRule extends \Espo\Core\Controllers\Record
+{
+}

files/custom/Espo/Modules/SmartAssistant/Services/DocumentAnalyzer.php

@@ -533,20 +533,37 @@ class DocumentAnalyzer
 
     private function extractFromDocx(string $tmpFile): ?string
     {
-        if (!class_exists(\PhpOffice\PhpWord\IOFactory::class)) return null;
+        // PHPWord (vendor/phpoffice/phpword) ships with the EspoCRM image but
-        $phpWord = \PhpOffice\PhpWord\IOFactory::load($tmpFile);
+        // is NOT in the composer PSR-4 autoload map — class_exists silently
-        $text = '';
+        // returns false. Rather than fix the autoloader (rebuild of the image)
-        foreach ($phpWord->getSections() as $section) {
+        // we parse word/document.xml directly. This is also more robust:
-            foreach ($section->getElements() as $element) {
+        // PHPWord's element walker only goes one level deep, missing text in
-                if (method_exists($element, 'getText')) $text .= $element->getText() . "\n";
+        // tables, hyperlinks, and footnotes.
-                elseif (method_exists($element, 'getElements')) {
+        $zip = new \ZipArchive();
-                    foreach ($element->getElements() as $child) {
+        if ($zip->open($tmpFile) !== true) {
-                        if (method_exists($child, 'getText')) $text .= $child->getText() . "\n";
+            $this->log->warning("SmartAssistant: extractFromDocx: not a valid zip: $tmpFile");
-                    }
+            return null;
+        }
+        $xml = $zip->getFromName('word/document.xml');
+        $zip->close();
+        if ($xml === false || $xml === '') {
+            $this->log->warning("SmartAssistant: extractFromDocx: word/document.xml missing in $tmpFile");
+            return null;
+        }
+
+        // Each <w:p> is a paragraph; concatenate <w:t> runs inside it.
+        // `(?:\s[^>]*)?` keeps us from also matching <w:tab> / <w:tbl>.
+        $paragraphs = [];
+        if (preg_match_all('#<w:p(?:\s[^>]*)?>(.*?)</w:p>#s', $xml, $pMatches)) {
+            foreach ($pMatches[1] as $block) {
+                if (preg_match_all('#<w:t(?:\s[^>]*)?>(.*?)</w:t>#s', $block, $tMatches)) {
+                    $line = trim(implode('', $tMatches[1]));
+                    if ($line !== '') $paragraphs[] = html_entity_decode($line, ENT_XML1 | ENT_QUOTES, 'UTF-8');
                 }
             }
         }
-        return $text ?: null;
+        $text = trim(implode("\n", $paragraphs));
+        return $text !== '' ? $text : null;
     }
 
     private function updateDocumentEntity(string $oldPath, string $newPath): void

manifest.json

@@ -3,11 +3,11 @@
     "module": "SmartAssistant",
     "description": "Unified AI Assistant for Legal CRM — floating chat with case memory, office alerts, and AI Gateway integration",
     "author": "klear",
-    "version": "2.9.0",
+    "version": "2.9.2",
     "acceptableVersions": [
         ">=8.0.0"
     ],
-    "releaseDate": "2026-05-14",
+    "releaseDate": "2026-05-27",
     "php": [
         ">=8.1"
     ]