fix(2.10.4): add missing clientDefs/AssistantRule.json

AssistantRule had no clientDefs file — the same gap that broke CaseMemory
in 2.10.2. Console showed:

  /client/custom/modules/smart-assistant/src/controllers/assistant-rule.js
  Failed to load resource: 404

Adding clientDefs/AssistantRule.json with controller: controllers/record
lets EspoCRM use the default record controller and stops the frontend
from probing for a non-existent module-specific controller file.

(2.10.3 had a force-push race against the auto-built zip, hence the
extra patch version.)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

files/custom/Espo/Modules/SmartAssistant/Controllers/CaseMemory.php

@@ -0,0 +1,17 @@
+<?php
+
+namespace Espo\Modules\SmartAssistant\Controllers;
+
+/**
+ * Standard CRUD over /api/v1/CaseMemory.
+ *
+ * Until SmartAssistant 2.10.0 the CaseMemory entity was created via
+ * CaseMemoryService::createMemory and listed via Case relation panels —
+ * never via the bare REST endpoint. Flipping `tab: true` exposes the
+ * navbar list view, which uses GET /api/v1/CaseMemory and needs this
+ * Controller class to exist (otherwise EspoCRM returns 404 "Controller
+ * does not exist"). Same pattern as the AssistantRule fix shipped in 2.9.2.
+ */
+class CaseMemory extends \Espo\Core\Controllers\Record
+{
+}

files/custom/Espo/Modules/SmartAssistant/Resources/metadata/clientDefs/AssistantRule.json

@@ -0,0 +1,10 @@
+{
+    "controller": "controllers/record",
+    "color": "#5e8c61",
+    "iconClass": "fas fa-list-check",
+    "boolFilterList": ["onlyMy"],
+    "filterList": [
+        {"name": "active"},
+        {"name": "inactive"}
+    ]
+}

files/custom/Espo/Modules/SmartAssistant/Resources/metadata/clientDefs/CaseMemory.json

@@ -0,0 +1,10 @@
+{
+    "controller": "controllers/record",
+    "color": "#9b59b6",
+    "iconClass": "fas fa-brain",
+    "boolFilterList": ["onlyMy"],
+    "filterList": [
+        {"name": "pinned"},
+        {"name": "byCategory"}
+    ]
+}

files/custom/Espo/Modules/SmartAssistant/Resources/metadata/scopes/AssistantRule.json

@@ -7,5 +7,7 @@
     "aclLevelList": ["all", "team", "own", "no"],
     "stream": false,
     "tab": true,
-    "disabled": false
+    "disabled": false,
+    "importable": false,
+    "customizable": true
 }

manifest.json

@@ -3,7 +3,7 @@
     "module": "SmartAssistant",
     "description": "Unified AI Assistant for Legal CRM — floating chat with case memory, office alerts, and AI Gateway integration",
     "author": "klear",
-    "version": "2.10.0",
+    "version": "2.10.4",
     "acceptableVersions": [
         ">=8.0.0"
     ],

scripts/AfterInstall.php

@@ -1,16 +1,19 @@
 <?php
-
-namespace Espo\Modules\SmartAssistant\Scripts;
+/**
+ * AfterInstall script for SmartAssistant extension 2.10.x.
+ *
+ * Idempotently seeds the AssistantPrompt entity with 7 default prompt
+ * sections (tool_rules, writing_style, legal_assistance, personality_case,
+ * personality_office, other_rules_case, other_rules_office). If a row with
+ * the same `key` already exists it is left alone — admin edits win.
+ *
+ * Class must be named `AfterInstall` with NO namespace — that's what the
+ * EspoCRM extension installer looks for in scripts/AfterInstall.php.
+ * See application/Espo/Core/Upgrades/ExtensionManager.php scriptNames map.
+ */
 
 use Espo\Core\Container;
 
-/**
- * Runs after the extension is installed/upgraded.
- *
- * Idempotent: only inserts AssistantPrompt rows whose `key` doesn't exist yet.
- * If the row exists (even with edits), we leave it alone — the user's
- * customizations win.
- */
 class AfterInstall
 {
     public function run(Container $container, $params = null): void
@@ -18,21 +21,11 @@ class AfterInstall
         $entityManager = $container->get('entityManager');
         $log = $container->get('log');
 
-        $resourceFile = __DIR__ . '/../files/custom/Espo/Modules/SmartAssistant/Resources/data/default-prompts.json';
-
-        if (!is_file($resourceFile)) {
-            // Fall back to the module Resources path when the extension is
-            // installed (Resources/ is the canonical location at runtime).
-            $resourceFile = dirname(__DIR__) . '/files/custom/Espo/Modules/SmartAssistant/Resources/data/default-prompts.json';
-        }
-
-        if (!is_file($resourceFile)) {
-            // Final fallback: the module's installed Resources path.
+        // The JSON file lives inside the installed module resources at runtime.
         $resourceFile = 'custom/Espo/Modules/SmartAssistant/Resources/data/default-prompts.json';
-        }
 
         if (!is_file($resourceFile)) {
-            $log->warning("[SmartAssistant] AfterInstall: default-prompts.json not found, skipping seed");
+            $log->warning("[SmartAssistant] AfterInstall: $resourceFile not found, skipping seed");
             return;
         }
 
@@ -40,7 +33,7 @@ class AfterInstall
         $defaults = json_decode($json, true);
 
         if (!is_array($defaults)) {
-            $log->warning("[SmartAssistant] AfterInstall: default-prompts.json invalid JSON");
+            $log->warning("[SmartAssistant] AfterInstall: invalid JSON in $resourceFile");
             return;
         }
 
@@ -72,7 +65,10 @@ class AfterInstall
                 'content' => $row['content'] ?? '',
                 'isActive' => true,
             ]);
-            $entityManager->saveEntity($entity);
+            // skipAll bypasses beforeSave hooks that require a logged-in user
+            // service (installer runs without an HTTP session) and ACL checks
+            // (we're seeding firm-wide defaults; no user is implicated).
+            $entityManager->saveEntity($entity, ['skipAll' => true]);
             $created++;
         }