From eb1b0fc7d4b7b24e8bf277f75037528ebf2a37d6 Mon Sep 17 00:00:00 2001 From: Chaim Date: Fri, 24 Apr 2026 16:01:03 +0000 Subject: [PATCH] chore: mark task #1 done after v0.1.8 release --- .taskmaster/tasks/tasks.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.taskmaster/tasks/tasks.json b/.taskmaster/tasks/tasks.json index 05f9279..38550db 100644 --- a/.taskmaster/tasks/tasks.json +++ b/.taskmaster/tasks/tasks.json @@ -5,7 +5,7 @@ "id": 1, "title": "feat: search-mode split-view with PDF + page jump", "description": "Render /kb/search results as a two-column split view: left column is the stack of ranked hit cards (kind, title, section, page label), right column is an iframe viewing the selected hit's PDF scrolled to page_number. Clicking any hit swaps the iframe. Text-only sources (law from Wikisource) fall back to a chunk/text panel with a Wikisource link so the right column never 404s.", - "status": "in-progress", + "status": "done", "priority": "high", "details": "Before this change renderSearchResults produced plain vertical text cards — users got the chunk body and had to open the Wikisource link (or track down the PDF manually) to verify context. With 5 of 5 PDFs now carrying accurate page_number (shira-hermes e534709 + 1ca1cc0), the search UI can finally deep-link to the right page. Mirrors the ask-mode split view (v0.1.7 uncommitted).", "testStrategy": "Search 'תקנה 37' → first hit should be a regulation/circular → right pane loads the PDF at page ~N where the section appears. Click a lower-ranked law hit → right pane swaps to a Wikisource link view. Search 'הגדרות' → hits span multiple sources → each click swaps iframe source.",